Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Refactored network/program/topology classes #6800

Merged
merged 7 commits into from
Aug 4, 2021
Merged

[GPU] Refactored network/program/topology classes #6800

merged 7 commits into from
Aug 4, 2021

Conversation

vladimir-paramuzov
Copy link
Contributor

@vladimir-paramuzov vladimir-paramuzov commented Jul 26, 2021 •
edited
Loading

Details:

  • Removed pimpl idiom usage for graph classes
  • Build options were moved to separate header
  • Added debug option for sources dump. Moved reading of DumpGraphs option to make it work in unit tests.

@vladimir-paramuzov vladimir-paramuzov added the category: GPU OpenVINO GPU plugin label Jul 26, 2021
@vladimir-paramuzov vladimir-paramuzov added this to the 2022.1 milestone Jul 26, 2021
@vladimir-paramuzov vladimir-paramuzov force-pushed the refactored_graph_api branch 4 times, most recently from 6dcf645 to 097154c Compare July 28, 2021 09:12
@vladimir-paramuzov vladimir-paramuzov marked this pull request as ready for review July 28, 2021 14:44
@vladimir-paramuzov vladimir-paramuzov requested review from a team as code owners July 28, 2021 14:44
sshlyapn
sshlyapn approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@sshlyapn sshlyapn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good to me

inference-engine/thirdparty/clDNN/api/cldnn/graph/program.hpp Outdated Show resolved Hide resolved
inference-engine/thirdparty/clDNN/src/network.cpp Show resolved Hide resolved
inference-engine/thirdparty/clDNN/src/network.cpp Show resolved Hide resolved
@vladimir-paramuzov vladimir-paramuzov merged commit 8f5d9a8 into openvinotoolkit:master Aug 4, 2021
@vladimir-paramuzov vladimir-paramuzov deleted the refactored_graph_api branch August 4, 2021 07:18
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
@vladimir-paramuzov
[GPU] Refactored network/program/topology classes (openvinotoolkit#6800)
5e43e94
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
@vladimir-paramuzov @andrei-cv
[GPU] Refactored network/program/topology classes (openvinotoolkit#6800)
afc7d4f
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@vladimir-paramuzov @akuporos
[GPU] Refactored network/program/topology classes (openvinotoolkit#6800)
4035cfe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshlyapn sshlyapn sshlyapn approved these changes

Assignees
No one assigned
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
2 participants
@vladimir-paramuzov @sshlyapn