Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acosh ref impl #6664

Merged
merged 12 commits into from
Jul 22, 2021
Merged

Acosh ref impl #6664

merged 12 commits into from
Jul 22, 2021

Conversation

pelszkow
Copy link
Contributor

@pelszkow pelszkow commented Jul 15, 2021

Details:

  • add ref impl for integer types
  • new template test
  • add visitor test
  • enable SLT

Tickets:

  • 37498
  • 45880
  • 45881
  • 53964

@pelszkow pelszkow added WIP work in progress do not merge labels Jul 15, 2021
@pelszkow pelszkow force-pushed the acosh_ref_impl branch 2 times, most recently from 5893767 to 06b8b64 Compare July 15, 2021 15:02
@pelszkow pelszkow requested review from sdurawa and mitruska July 16, 2021 09:41
@pelszkow pelszkow removed WIP work in progress do not merge labels Jul 16, 2021
@pelszkow pelszkow requested a review from mitruska July 16, 2021 10:25
@pelszkow pelszkow marked this pull request as ready for review July 16, 2021 10:35
@pelszkow pelszkow requested a review from a team as a code owner July 16, 2021 10:35
@pelszkow pelszkow requested review from a team July 16, 2021 10:35
@pelszkow pelszkow requested review from rkazants and ilyachur July 19, 2021 04:32
@pelszkow pelszkow force-pushed the acosh_ref_impl branch 2 times, most recently from acd9e0d to 6c66a7a Compare July 19, 2021 13:16
@pelszkow
Copy link
Contributor Author

@ilyachur, can you review and merge this PR?

@ilyachur
Copy link
Contributor

@pelszkow Please rebase your PR to the latest master. I see that some new tests already exist in the master branch.

@ilyachur ilyachur added the category: Core OpenVINO Core (aka ngraph) label Jul 21, 2021
@ilyachur ilyachur added this to the 2022.2 milestone Jul 21, 2021
@ilyachur ilyachur modified the milestones: 2022.2, 2022.1 Jul 21, 2021
@pelszkow
Copy link
Contributor Author

PR updated to current master. Waiting for CI.

@pelszkow pelszkow requested a review from ilyachur July 21, 2021 06:06
@ilyachur ilyachur self-assigned this Jul 21, 2021
@pelszkow pelszkow force-pushed the acosh_ref_impl branch 3 times, most recently from fe58c12 to d67ad41 Compare July 22, 2021 04:33
@ilyachur ilyachur enabled auto-merge (squash) July 22, 2021 08:56
@ilyachur ilyachur merged commit 35fb3f3 into openvinotoolkit:master Jul 22, 2021
@pelszkow pelszkow deleted the acosh_ref_impl branch July 27, 2021 06:33
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
* minor changes in Op class and add ref impl for acosh

* acosh in new test framework

* add Acosh type test

* add SLT for Acosh

* run more test

* new acosh plugin test

* add visitor test

* fix test utils

* add template test for all supported types in Acosh

* add builder to template tests

* update grn template_plugin test

* update maste to feature branch
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
* minor changes in Op class and add ref impl for acosh

* acosh in new test framework

* add Acosh type test

* add SLT for Acosh

* run more test

* new acosh plugin test

* add visitor test

* fix test utils

* add template test for all supported types in Acosh

* add builder to template tests

* update grn template_plugin test

* update maste to feature branch
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
* minor changes in Op class and add ref impl for acosh

* acosh in new test framework

* add Acosh type test

* add SLT for Acosh

* run more test

* new acosh plugin test

* add visitor test

* fix test utils

* add template test for all supported types in Acosh

* add builder to template tests

* update grn template_plugin test

* update maste to feature branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants