Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise sign #6581

Merged
merged 21 commits into from
Jul 20, 2021
Merged

Revise sign #6581

merged 21 commits into from
Jul 20, 2021

Conversation

pszmel
Copy link
Contributor

@pszmel pszmel commented Jul 9, 2021

Details:

  • update docs
  • add RTTI macro
  • create visitor test
  • update backend test
  • create type_prop tests
  • add op to constants.py
  • add to SLT int tests

Tickets:

  • 37477

@pszmel pszmel requested a review from a team as a code owner July 9, 2021 10:00
@pszmel pszmel requested review from a team July 9, 2021 10:00
@openvino-pushbot openvino-pushbot added category: docs OpenVINO documentation category: IE Tests OpenVINO Test: plugins and common category: Core OpenVINO Core (aka ngraph) labels Jul 9, 2021
@pszmel pszmel marked this pull request as draft July 9, 2021 10:00
@pszmel pszmel removed request for a team July 9, 2021 10:01
@pszmel pszmel marked this pull request as ready for review July 13, 2021 20:19
@pszmel pszmel requested review from ilyachur and sdurawa July 13, 2021 20:19
@pszmel pszmel requested a review from lazarevevgeny July 13, 2021 20:20
@ilyachur ilyachur assigned rkazants and unassigned rkazants Jul 15, 2021
@ilyachur ilyachur requested a review from rkazants July 15, 2021 04:29
@ilyachur ilyachur added this to the 2022.1 milestone Jul 15, 2021
@ilyachur
Copy link
Contributor

@rkazants Please have a look

ilyachur
ilyachur reviewed Jul 15, 2021
View reviewed changes
docs/template_plugin/tests/functional/op_reference/sign.cpp Outdated
struct SignParams {
template <class IT, class OT>
SignParams(const ngraph::PartialShape& shape, const ngraph::element::Type& iType, const ngraph::element::Type& oType, const std::vector<IT>& iValues,
const std::vector<OT>& oValues, size_t iSize = 0, size_t oSize = 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that you need to have iSize, oSize. You always work with default types

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, removed.

docs/template_plugin/tests/functional/op_reference/sign.cpp Show resolved Hide resolved
@pszmel pszmel requested a review from ilyachur July 15, 2021 12:25
ilyachur
ilyachur reviewed Jul 16, 2021
View reviewed changes
Copy link
Contributor

@ilyachur ilyachur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update serialization tests?

docs/template_plugin/tests/functional/op_reference/sign.cpp Show resolved Hide resolved
@pszmel pszmel requested a review from ilyachur July 16, 2021 08:56
ilyachur
ilyachur approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@ilyachur ilyachur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkazants Could you check specification style?

@ilyachur ilyachur merged commit c2c6fe5 into openvinotoolkit:master Jul 20, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
@pszmel
Revise sign (openvinotoolkit#6581)
5321173 
* update docs

* add sign to intActivationTypes

* add RTTI macro

* update backend test

* add type prp test

* add visitor test

* add visitor and type_prop test to CMakeList

* add sign to constants.py

* delete backend tests and create new reference tests

* style fix

* remoove sign backend test from CMakeList

* create reference test for all supported types

* remove boolean type from evaluate method
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
@pszmel @andrei-cv
Revise sign (openvinotoolkit#6581)
367e2e3 
* update docs

* add sign to intActivationTypes

* add RTTI macro

* update backend test

* add type prp test

* add visitor test

* add visitor and type_prop test to CMakeList

* add sign to constants.py

* delete backend tests and create new reference tests

* style fix

* remoove sign backend test from CMakeList

* create reference test for all supported types

* remove boolean type from evaluate method
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@pszmel @akuporos
Revise sign (openvinotoolkit#6581)
9b39799 
* update docs

* add sign to intActivationTypes

* add RTTI macro

* update backend test

* add type prp test

* add visitor test

* add visitor and type_prop test to CMakeList

* add sign to constants.py

* delete backend tests and create new reference tests

* style fix

* remoove sign backend test from CMakeList

* create reference test for all supported types

* remove boolean type from evaluate method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkazants rkazants rkazants approved these changes

@ilyachur ilyachur ilyachur approved these changes

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: docs OpenVINO documentation category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
4 participants
@pszmel @ilyachur @rkazants @openvino-pushbot