Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MulticlassNms/MatrixNms: ngraph python api #6573

Merged
merged 7 commits into from
Jul 14, 2021
Merged

MulticlassNms/MatrixNms: ngraph python api #6573

merged 7 commits into from
Jul 14, 2021

Conversation

luo-cheng2021
Copy link
Contributor

Details:

  • python api for MulticlassNms/MatrixNms

Tickets:

  • 56923
  • 56907

@luo-cheng2021 luo-cheng2021 requested a review from a team July 9, 2021 02:27
@openvino-pushbot openvino-pushbot added the category: Core OpenVINO Core (aka ngraph) label Jul 9, 2021
@luo-cheng2021
Copy link
Contributor Author

@postrational @ilyachur @GlebKazantaev Could you please have a look, thanks.

@ilyachur ilyachur requested review from postrational and jiwaszki July 9, 2021 06:58
@ilyachur ilyachur added this to the 2022.1 milestone Jul 9, 2021
jiwaszki
jiwaszki approved these changes Jul 9, 2021
View reviewed changes
Copy link

@jiwaszki jiwaszki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilyachur ilyachur requested a review from jiwaszki July 12, 2021 03:12
@ilyachur
Copy link
Contributor

@luo-cheng2021 Please fix CI

jiwaszki
jiwaszki reviewed Jul 12, 2021
View reviewed changes
Copy link

@jiwaszki jiwaszki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openvino/ngraph/python/src/pyngraph/node_factory.cpp

Line 89 in 8fb1182

const ngraph::OpSet& m_opset = ngraph::get_opset7();

You should also update this afaik

@luo-cheng2021
Copy link
Contributor Author

openvino/ngraph/python/src/pyngraph/node_factory.cpp

Line 89 in 8fb1182

const ngraph::OpSet& m_opset = ngraph::get_opset7();

You should also update this afaik

Done.

@luo-cheng2021
Copy link
Contributor Author

@luo-cheng2021 Please fix CI

Done

@luo-cheng2021 luo-cheng2021 requested a review from jiwaszki July 13, 2021 05:07
@ilyachur ilyachur merged commit 2378593 into openvinotoolkit:master Jul 14, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
@luo-cheng2021
MulticlassNms/MatrixNms: ngraph python api (openvinotoolkit#6573)
f0e5bb0 
* nms python api

* fix python code style

* fix python code style

* apply review comments

* apply review comments
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
@luo-cheng2021 @andrei-cv
MulticlassNms/MatrixNms: ngraph python api (openvinotoolkit#6573)
f499cf0 
* nms python api

* fix python code style

* fix python code style

* apply review comments

* apply review comments
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@luo-cheng2021 @akuporos
MulticlassNms/MatrixNms: ngraph python api (openvinotoolkit#6573)
0367606 
* nms python api

* fix python code style

* fix python code style

* apply review comments

* apply review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiwaszki jiwaszki jiwaszki approved these changes

@ilyachur ilyachur ilyachur approved these changes

@postrational postrational Awaiting requested review from postrational

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
4 participants
@luo-cheng2021 @ilyachur @jiwaszki @openvino-pushbot