Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeformableConv v8: reference implementation #6514

Merged

Conversation

itikhono
Copy link
Contributor

@itikhono itikhono commented Jul 5, 2021

Details:

  • Reference implementation
  • Evaluate method: added temporarily, will be removed after merge of cpu implementation
  • Tests

Tickets:

  • 56580

@itikhono itikhono added the category: Core OpenVINO Core (aka ngraph) label Jul 5, 2021
@itikhono itikhono added this to the 2022.1 milestone Jul 5, 2021
Copy link
Contributor

@ilyachur ilyachur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itikhono Please have a look to PR: #6393

@itikhono itikhono requested a review from ilyachur July 7, 2021 07:04
@itikhono itikhono requested a review from nosovmik July 7, 2021 15:32
@ggalieroc-zz
Copy link

Removing myself as am OOO. @jdanieck can cover the review

@ggalieroc-zz ggalieroc-zz removed their request for review July 8, 2021 07:08
@itikhono itikhono requested a review from nosovmik July 8, 2021 07:58
@itikhono itikhono requested review from a team July 14, 2021 03:02
@itikhono
Copy link
Contributor Author

@jdanieck could you look at this PR?

Copy link
Contributor

@jdanieck jdanieck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. One concern regarding SLTs, I don't see them in this PR so it should be planned to add them as they will be needed for plugins.

@itikhono
Copy link
Contributor Author

Single layer tests will be added in PR with CPU implementation

Copy link
Contributor

@ilyachur ilyachur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add SLT for CPU plugin?

@ilyachur
Copy link
Contributor

Single layer tests will be added in PR with CPU implementation

I think it can be added in this PR, in order to check that ref implementation works as expected in the CPU plugin

@itikhono itikhono requested review from a team and ilyachur July 15, 2021 10:09
@ilyachur ilyachur merged commit 697c52a into openvinotoolkit:master Jul 19, 2021
azhogov pushed a commit to azhogov/openvino that referenced this pull request Jul 21, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
* DeformableConv v8:reference implementation

* ngraph codestyle

* update reference iplementation

* Disable tests on GPU

* fix unit tests

* Update DeformConv single layer tests

* fix serialization tests
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
* DeformableConv v8:reference implementation

* ngraph codestyle

* update reference iplementation

* Disable tests on GPU

* fix unit tests

* Update DeformConv single layer tests

* fix serialization tests
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
* DeformableConv v8:reference implementation

* ngraph codestyle

* update reference iplementation

* Disable tests on GPU

* fix unit tests

* Update DeformConv single layer tests

* fix serialization tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants