-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeformableConv v8: reference implementation #6514
DeformableConv v8: reference implementation #6514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…rm_conv/reference_impl
…rm_conv/reference_impl
ngraph/core/reference/include/ngraph/runtime/reference/deformable_convolution.hpp
Show resolved
Hide resolved
ngraph/core/reference/include/ngraph/runtime/reference/deformable_convolution.hpp
Show resolved
Hide resolved
…rm_conv/reference_impl
Removing myself as am OOO. @jdanieck can cover the review |
…rm_conv/reference_impl
@jdanieck could you look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. One concern regarding SLTs, I don't see them in this PR so it should be planned to add them as they will be needed for plugins.
Single layer tests will be added in PR with CPU implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add SLT for CPU plugin?
I think it can be added in this PR, in order to check that ref implementation works as expected in the CPU plugin |
…rm_conv/reference_impl
…rm_conv/reference_impl
…rm_conv/reference_impl
* DeformableConv v8:reference implementation * ngraph codestyle * update reference iplementation * Disable tests on GPU * fix unit tests * Update DeformConv single layer tests * fix serialization tests
* DeformableConv v8:reference implementation * ngraph codestyle * update reference iplementation * Disable tests on GPU * fix unit tests * Update DeformConv single layer tests * fix serialization tests
* DeformableConv v8:reference implementation * ngraph codestyle * update reference iplementation * Disable tests on GPU * fix unit tests * Update DeformConv single layer tests * fix serialization tests
Details:
Tickets: