Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select operation revision #6483

Merged
merged 18 commits into from
Jul 21, 2021
Merged

Select operation revision #6483

merged 18 commits into from
Jul 21, 2021

Conversation

jdanieck
Copy link
Contributor

@jdanieck jdanieck commented Jul 1, 2021 •
edited
Loading

Details:

  • Added Serialization SLT
  • Added Visitor tests
  • Added Select-1 to summarize.py
  • Remove Select from evaluates_map
  • Migrated backend tests to template plugin
  • Remove Select tests from manifest
  • Refactored CoordinateTransform usage to "CoordinateTransformBasic/row_major_strides" pattern (benchmarks results in the ticket)
  • PDPD broadcasting implementation aligned to spec - new order of tensor broadcasting is then <- else <- cond; before was else <- if <- cond;

Tickets:

  • 37531

@jdanieck jdanieck added the category: Core OpenVINO Core (aka ngraph) label Jul 1, 2021
@jdanieck jdanieck added this to the 2022.1 milestone Jul 1, 2021
@jdanieck jdanieck self-assigned this Jul 1, 2021
@jdanieck

This comment has been minimized.

Sign in to view
@jdanieck jdanieck requested a review from pelszkow July 13, 2021 11:43
@jdanieck

This comment has been minimized.

Sign in to view
@jdanieck
Copy link
Contributor Author

@ilyachur could you find someone who is familiar with PDPD broadcasting to review this PR? I changed order of tensor broadcasting to be aligned with spec and with reference implementation. It was not tested before and when I added unit tests I discovered it is not working (in my understanding). This can break backward compatibility, so we need to asses this change carefully.

@jdanieck jdanieck requested a review from ilyachur July 16, 2021 07:19
@jdanieck jdanieck marked this pull request as ready for review July 16, 2021 07:19
@jdanieck jdanieck requested a review from a team as a code owner July 16, 2021 07:19
@jdanieck jdanieck requested a review from a team July 16, 2021 07:19
@jdanieck jdanieck requested review from a team and pelszkow and removed request for a team July 16, 2021 07:19
@jdanieck jdanieck assigned pelszkow and unassigned jdanieck Jul 16, 2021
@jdanieck
Copy link
Contributor Author

@pelszkow please take care of this PR starting from Monday as I am out of project starting next week. I'll be available to all consultations you need, just won't be making code changes anymore.

@ilyachur ilyachur merged commit 226cb95 into openvinotoolkit:master Jul 21, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
@jdanieck
Select operation revision (openvinotoolkit#6483)
e45194f 
* Add visitor test.

* Add Serialization SLT.

* Add Select-1 to summarize.py.

* Remove select from evaluates map.

* Remove few Select cases from manifest.

* Fix style.

* Refactor CoordinateTransform usage for NUMPY.

* Refactor CoordinateTransform usage for PDPD.

* Migrate backend tests to template_plugin.

* Revert "Fix style."

This reverts commit 8298c90.

* Add more template plugin tests.

* Fixes for PDPD broadcasting.

* Align Select type prop tests with PDPP broadcasting to new
implementation.

* Remove ngraph:: from types in tests.
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
@jdanieck @andrei-cv
Select operation revision (openvinotoolkit#6483)
768982c 
* Add visitor test.

* Add Serialization SLT.

* Add Select-1 to summarize.py.

* Remove select from evaluates map.

* Remove few Select cases from manifest.

* Fix style.

* Refactor CoordinateTransform usage for NUMPY.

* Refactor CoordinateTransform usage for PDPD.

* Migrate backend tests to template_plugin.

* Revert "Fix style."

This reverts commit 8298c90.

* Add more template plugin tests.

* Fixes for PDPD broadcasting.

* Align Select type prop tests with PDPP broadcasting to new
implementation.

* Remove ngraph:: from types in tests.
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@jdanieck @akuporos
Select operation revision (openvinotoolkit#6483)
9d2acbc 
* Add visitor test.

* Add Serialization SLT.

* Add Select-1 to summarize.py.

* Remove select from evaluates map.

* Remove few Select cases from manifest.

* Fix style.

* Refactor CoordinateTransform usage for NUMPY.

* Refactor CoordinateTransform usage for PDPD.

* Migrate backend tests to template_plugin.

* Revert "Fix style."

This reverts commit 8298c90.

* Add more template plugin tests.

* Fixes for PDPD broadcasting.

* Align Select type prop tests with PDPP broadcasting to new
implementation.

* Remove ngraph:: from types in tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelszkow pelszkow pelszkow approved these changes

@ilyachur ilyachur ilyachur approved these changes

Assignees

@pelszkow pelszkow

Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jdanieck @ilyachur @pelszkow