Eltwise shared test refactor #645
Conversation
kmagiers
requested review from
iefode,
esmirno,
dorloff,
pavel-rodionov and
a team
| const std::vector<InferenceEngine::Precision> netPrecisions = { | ||
| InferenceEngine::Precision::FP32, | ||
| InferenceEngine::Precision::FP16 | ||
| std::vector<std::vector<std::vector<size_t>>> inputShapes = { {std::vector<std::size_t>({1, 30})} }; |
There was a problem hiding this comment.
As in test for Multiply layer we can also add more input shapes here
There was a problem hiding this comment.
Sure, I'll add additional shapes, I simply left the "original" shapes of the test
|
Also could you please re-name your PR so it won't be confusing. Because you are not just removing test for Eltwise layer - your are replacing it for another tests that are actually better. |
| @@ -0,0 +1,71 @@ | |||
| // Copyright (C) 2020 Intel Corporation | |||
There was a problem hiding this comment.
@dmitry-gorokhov Please review updated/added CPU plugin instances
There was a problem hiding this comment.
After discussion with @dmitry-gorokhov, we have take a decision to make single eltwise tests file instead of existing. Dmitry had more powerful argument in our discussion.
I will use this PR in merge of these tests. Sorry for inconvenience.
So, This PR is not to be merged.
There was a problem hiding this comment.
@iefode, can you please elaborate on "I will use this PR in merge of these tests" - what do you mean?
There was a problem hiding this comment.
I will refactor these chanes in the refactoring
There was a problem hiding this comment.
Refactor in the refactoring? It's still unclear. Is anything expected from our side?
There was a problem hiding this comment.
I will do it myself. I don't expected some actions from your side
...ce-engine/tests/functional/plugin/gna/shared_tests_instances/single_layer_tests/subtract.cpp
Outdated
Show resolved
Hide resolved
inference-engine/tests/functional/plugin/gna/shared_tests_instances/single_layer_tests/add.cpp
Outdated
Show resolved
Hide resolved
inference-engine/tests/functional/plugin/shared/src/single_layer_tests/subtract.cpp
Outdated
Show resolved
Hide resolved
kmagiers
force-pushed
the
Eltwise_shared_test_removal
branch
from
25f636c to
421f83d
Compare
|
PR: #726 merged to the master. This PR should be closed |
* [NVIDIA] Fix CudaUnitTests target for Windows * [NVIDIA] Fix CUDA::math::pow function * [NVIDIA] Fix Windows build error in convert_benchmark.cpp --------- Co-authored-by: Nadezhda Ageeva <[email protected]>
Removal of Eltwise test
Extension of Add test
Extension of Multiply test
Introduction of Subtract test