Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise cos #6429

Merged
merged 17 commits into from
Jun 30, 2021
Merged

Revise cos #6429

merged 17 commits into from
Jun 30, 2021

Conversation

pszmel
Copy link
Contributor

@pszmel pszmel commented Jun 29, 2021

Details:

  • update docs
  • add RTTI macro
  • create reference impl for int input
  • create visitor test
  • create backend test for int input
  • create type_prop tests

Tickets:

  • 37431

@pszmel pszmel marked this pull request as ready for review June 29, 2021 10:55
@pszmel pszmel requested a review from a team as a code owner June 29, 2021 10:55
@pszmel pszmel requested review from a team and ilyachur June 29, 2021 10:55
@ggalieroc-zz
Copy link

As changes required for revising Cos op are small, this PR comprises all sub-tasks:
@lazarevevgeny, could you please review the spec part?
@iefode, SLTs with int precision have been added + op added to trusted op list

cc @bszmelcz this PR is similar to the one you are currently working in. Please have a look

@ggalieroc-zz ggalieroc-zz requested review from iefode and removed request for a team June 29, 2021 11:25
Copy link
Contributor

@ilyachur ilyachur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lazarevevgeny please review the specification

@ggalieroc-zz ggalieroc-zz mentioned this pull request Jun 30, 2021
@ggalieroc-zz
Copy link

Also add checks for inputs/outputs in evaluate method, similarly as in here

@pszmel
Copy link
Contributor Author

pszmel commented Jun 30, 2021

@ggalieroc added check.

@lazarevevgeny lazarevevgeny enabled auto-merge (squash) June 30, 2021 15:00
@ggalieroc-zz ggalieroc-zz mentioned this pull request Jun 30, 2021
@lazarevevgeny lazarevevgeny merged commit 6d5e6de into openvinotoolkit:master Jun 30, 2021
@tiger100256-hu tiger100256-hu mentioned this pull request Jul 12, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
* Update docs

* create type_prop test for cos

* Create visitor test foor cos

* add RTTI macro

* Create separate ref impl for integer input

* add cos to SLT integer activation type

* add backend test for int input

* add cos to constants.py

* style apply

* fix spec

* add ngraph check for outputs and inputs

* fix inputs ngraph check

* remove unnecessary includes

* style dix
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
* Update docs

* create type_prop test for cos

* Create visitor test foor cos

* add RTTI macro

* Create separate ref impl for integer input

* add cos to SLT integer activation type

* add backend test for int input

* add cos to constants.py

* style apply

* fix spec

* add ngraph check for outputs and inputs

* fix inputs ngraph check

* remove unnecessary includes

* style dix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants