Avoid Constant data copy inside Reshape constant folding #6410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlebKazantaev
force-pushed
the
gkazanta/const_reshape_optimization
branch
from
e2e6347 to
72d58e9
Compare
GlebKazantaev
force-pushed
the
gkazanta/const_reshape_optimization
branch
from
c980aea to
0878007
Compare
|
Lets make it for (Un)Squeeze too |
ilyachur
reviewed
Jul 28, 2021
GlebKazantaev
force-pushed
the
gkazanta/const_reshape_optimization
branch
from
0878007 to
e173a02
Compare
jane-intel
reviewed
Jul 28, 2021
jane-intel
approved these changes
Jul 28, 2021
ilyachur
approved these changes
Jul 29, 2021
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
…lkit#6410) * Avoid Constant data copy inside Reshape constant folding * Fix Codestyle * Updated Squeeze, Unsqueeze cf * Deprecate set_data_shape method * Fix Pruning
andrei-cv
pushed a commit
to andrei-cv/openvino
that referenced
this pull request
Aug 30, 2021
…lkit#6410) * Avoid Constant data copy inside Reshape constant folding * Fix Codestyle * Updated Squeeze, Unsqueeze cf * Deprecate set_data_shape method * Fix Pruning
akuporos
pushed a commit
to akuporos/openvino
that referenced
this pull request
Sep 29, 2021
…lkit#6410) * Avoid Constant data copy inside Reshape constant folding * Fix Codestyle * Updated Squeeze, Unsqueeze cf * Deprecate set_data_shape method * Fix Pruning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change optimizes Reshape operation constant folding. In more cases Constant which goes to Reshape has more than one consumer (because we make function copy with shared constants) so the previous optimization wasn't efficient in most cases. But with this changes we don't make Constant data copy anymore because we now create Constant with shared data but with different shape.