Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maxpool-8 shell #6332

Merged
merged 29 commits into from
Aug 3, 2021
Merged

Maxpool-8 shell #6332

merged 29 commits into from
Aug 3, 2021

Conversation

tomdol
Copy link
Contributor

@tomdol tomdol commented Jun 23, 2021

Details:

  • MaxPool-8 operator shell implementation
  • Common members and shape inference utilities moved to a base class that both MaxPool version derive from
  • Includes attribute visitor and type_prop tests
  • The implementation is based on Propose new MaxPool-8 operation #5359 which might get adjusted in a few days

Tickets:

  • 54658

@tomdol tomdol requested a review from a team June 23, 2021 20:27
@openvino-pushbot openvino-pushbot added the category: Core OpenVINO Core (aka ngraph) label Jun 23, 2021
@tomdol tomdol requested review from lazarevevgeny and mvafin June 24, 2021 11:25
@andrei-kochin
Copy link
Contributor

@ilyachur @a-sidorova Please review nGraph shell implementation for MaxPool-8

ngraph/core/include/ngraph/op/max_pool.hpp Outdated Show resolved Hide resolved
ngraph/core/include/ngraph/op/max_pool.hpp Show resolved Hide resolved
ngraph/core/include/ngraph/op/util/max_pool_base.hpp Outdated Show resolved Hide resolved
ngraph/core/src/op/max_pool.cpp Outdated Show resolved Hide resolved
@ilyachur ilyachur merged commit e000c52 into openvinotoolkit:master Aug 3, 2021
@tomdol tomdol deleted the maxpool-8 branch August 4, 2021 14:31
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
* Initial version of v8::MaxPool op class

* Type instead of Type_t to indicate element type

* Attribute visitor test

* Common MaxPoolBase base class

* More refactoring

* v8::MaxPool cleanup

* Pooling ops inference helper extension - window dilation

* New MaxPool 3D type prop tests

* Common part of MaxPool validation part extracted to the base class

* MaxPool-8 shape inference with base class utils

* infer_batched_pooling_forward arguments reorder to avoid compilation errors

* Align the rounding type attribute name for both MaxPool version

* MaxPool-8 axis attribute

* Missing attributes

* Code formatting

* PR feedback

* MaxPool-1 RTTI definition adjustment
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
* Initial version of v8::MaxPool op class

* Type instead of Type_t to indicate element type

* Attribute visitor test

* Common MaxPoolBase base class

* More refactoring

* v8::MaxPool cleanup

* Pooling ops inference helper extension - window dilation

* New MaxPool 3D type prop tests

* Common part of MaxPool validation part extracted to the base class

* MaxPool-8 shape inference with base class utils

* infer_batched_pooling_forward arguments reorder to avoid compilation errors

* Align the rounding type attribute name for both MaxPool version

* MaxPool-8 axis attribute

* Missing attributes

* Code formatting

* PR feedback

* MaxPool-1 RTTI definition adjustment
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
* Initial version of v8::MaxPool op class

* Type instead of Type_t to indicate element type

* Attribute visitor test

* Common MaxPoolBase base class

* More refactoring

* v8::MaxPool cleanup

* Pooling ops inference helper extension - window dilation

* New MaxPool 3D type prop tests

* Common part of MaxPool validation part extracted to the base class

* MaxPool-8 shape inference with base class utils

* infer_batched_pooling_forward arguments reorder to avoid compilation errors

* Align the rounding type attribute name for both MaxPool version

* MaxPool-8 axis attribute

* Missing attributes

* Code formatting

* PR feedback

* MaxPool-1 RTTI definition adjustment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants