[IE CLDNN] disabled crop optimization prior to NMS #6015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeonbok
requested review from
geunhwan,
yunji-yunji,
a user,
isanghao,
kelvinchoi-intel,
ahnyoung-paul and
vladimir-paramuzov
yeonbok
force-pushed
the
taylor_fix_crop_nms
branch
from
15d6947 to
fbdb585
Compare
|
In the long-term, I think the proper method is to support padding from NMS. If NMS does not support padding, we need to check and reject it. |
ghost
mentioned this pull request
…p will add unexpected padding while NMS cannot handle it properly
yeonbok
force-pushed
the
taylor_fix_crop_nms
branch
from
fbdb585 to
f05e703
Compare
vladimir-paramuzov
approved these changes
Jun 4, 2021
yekruglov
pushed a commit
to yekruglov/openvino
that referenced
this pull request
Jun 7, 2021
…p will add unexpected padding while NMS cannot handle it properly (openvinotoolkit#6015)
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
…p will add unexpected padding while NMS cannot handle it properly (openvinotoolkit#6015)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
crop + NMS should not be merged because optimizing out crop will add padding input for NMS while NMS is not supporting padding currently
Tickets: