Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather->ShapeOf optimization fix #6006

Merged
merged 3 commits into from
Jun 3, 2021

Conversation

jane-intel
Copy link
Contributor

Details:

  • Took Shape Of output type into account while applying the transformation

Tickets:

  • 57277

@jane-intel jane-intel added the category: Core OpenVINO Core (aka ngraph) label Jun 2, 2021
@jane-intel jane-intel requested a review from GlebKazantaev June 2, 2021 15:31
@jane-intel jane-intel requested a review from ilyachur as a code owner June 2, 2021 15:31
@jane-intel jane-intel enabled auto-merge (squash) June 2, 2021 21:56
@@ -93,7 +93,7 @@ static bool simplify_gather_shapeof(shared_ptr<Node> node) {

auto zero_axis = opset3::Constant::create<int64_t>(element::i64, Shape{}, {0});
NodeVector new_ops;
auto new_shapeof = make_shared<opset3::ShapeOf>(gather->input_value(0));
auto new_shapeof = make_shared<opset3::ShapeOf>(gather->input_value(0), node->get_output_element_type(0));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add new tests?

@jane-intel jane-intel merged commit 5494280 into openvinotoolkit:master Jun 3, 2021
yekruglov pushed a commit to yekruglov/openvino that referenced this pull request Jun 7, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
@jane-intel jane-intel deleted the gather_shape_of_fix branch May 26, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants