[GNA] Support for cascade concat with non functional layers #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
admitriev-gna
force-pushed
the
private/ad/permute
branch
from
f13f779 to
78fb0fd
Compare
admitriev-gna
force-pushed
the
private/ad/permute
branch
from
78fb0fd to
a0da4d0
Compare
| @@ -550,6 +550,23 @@ void GNAGraphCompiler::ConcatPrimitive(InferenceEngine::CNNLayerPtr layer) { | |||
| auto& concatLayerInfo = concat_connection.find(concatLayer->name)->second; | |||
| for (auto &&outLayer : concatLayer->outData.front()->getInputTo()) { | |||
| if ( LayerInfo(outLayer.second).isConcat() ) { | |||
| auto concatCadidate = outLayer.second; | |||
| #include <memory> | ||
| #include "functional_test_utils/layer_test_utils.hpp" | ||
| #include "ngraph_functions/builders.hpp" | ||
| #include "ngraph_functions/utils/ngraph_helpers.hpp" |
There was a problem hiding this comment.
I'm sorry but do you actually use something form ngraph_helpers.hpp here in this header?
| #include <string> | ||
| #include <vector> | ||
| #include <memory> | ||
| #include <debug.h> |
There was a problem hiding this comment.
Why do we need this?
| const_concat2->output(0)}, | ||
| 0); | ||
| auto const_mul = ngraph::builder::makeConstant(ngPrc, ngraph::Shape{1}, std::vector<float>{-1.0f}); | ||
| auto mult = std::make_shared<ngraph::opset1::Multiply>(input[0], const_mul); |
There was a problem hiding this comment.
For consistency I can suggest your to use const_mul and mul or const_mult and mult
esmirno
reviewed
May 29, 2020
| function = std::make_shared<ngraph::Function>(mult, input, "concat_reshape_reshape_concat_mul"); | ||
| } | ||
|
|
||
| TEST_P(ConcatReshapeReshapeConcatMul, CompareWithRefs){ |
There was a problem hiding this comment.
why we are not creating unit tests at all? Functional test to me only should happen if fight with accuracy. And event than it is questionable.
esmirno
suggested changes
May 29, 2020
| if (!CNNNetHasNextLayerSkipCertain(concatCadidate, 0, 0, isNonFunctional)) { | ||
| continue; | ||
| } | ||
| concatCadidate = CNNNetGetNextLayerSkipCertain(concatCadidate, 0, 0, isNonFunctional).first; |
There was a problem hiding this comment.
what if there will be non linear subgraph of reshapes? What functional layer will be ended up with?
Create a case concat->reshape->(out:0)affine, (out:1 )concat
admitriev-gna
force-pushed
the
private/ad/permute
branch
7 times, most recently
from
59721ac to
2e75b62
Compare
admitriev-gna
force-pushed
the
private/ad/permute
branch
4 times, most recently
from
0932d40 to
3b5b328
Compare
dorloff
requested changes
Jun 30, 2020
inference-engine/tests/functional/plugin/shared/src/subgraph_tests/cascade_concat.cpp
Show resolved
Hide resolved
admitriev-gna
force-pushed
the
private/ad/permute
branch
from
3b5b328 to
eee8614
Compare
dorloff
reviewed
Jul 9, 2020
inference-engine/tests/functional/plugin/shared/src/subgraph_tests/cascade_concat.cpp
Outdated
Show resolved
Hide resolved
admitriev-gna
force-pushed
the
private/ad/permute
branch
from
eee8614 to
52b79bb
Compare
admitriev-gna
force-pushed
the
private/ad/permute
branch
from
52b79bb to
0d1e0e7
Compare
dorloff
approved these changes
Jul 10, 2020
admitriev-gna
force-pushed
the
private/ad/permute
branch
from
0d1e0e7 to
e12b804
Compare
esmirno
approved these changes
Jul 27, 2020
…oncats [GNA] Support for cascade concat with non functional layers between concats [GNA] Support for cascade concat with non functional layers between concats fix discussion medn test delete commet Rework test minor fix last fix Test Align filter fix discussion
admitriev-gna
force-pushed
the
private/ad/permute
branch
from
e12b804 to
075ae03
Compare
RomanZm
pushed a commit
to RomanZm/openvino
that referenced
this pull request
Aug 28, 2020
…oncats (openvinotoolkit#598) [GNA] Support for cascade concat with non functional layers between concats
tadamowicz
pushed a commit
to tadamowicz/openvino
that referenced
this pull request
Aug 30, 2023
…oncats (openvinotoolkit#598) [GNA] Support for cascade concat with non functional layers between concats
redradist
pushed a commit
to redradist/openvino
that referenced
this pull request
Oct 6, 2023
…it#598) * Modify OPENVINO_OP using, caused by deprecated version Signed-off-by: xuejun <[email protected]> * Fix review comments Signed-off-by: xuejun <[email protected]> --------- Signed-off-by: xuejun <[email protected]> Co-authored-by: Ilya Lavrenov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for cascade concat with non functional layers between concats.
Added tests for cascade concat