Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MO] Add extractor for ONNX *OrEqual operations #5932

Conversation

achetver
Copy link
Contributor

@achetver achetver commented May 31, 2021

Root cause analysis: Extractor for ONNX operations GreaterOrEqual and LessOrEqual not exist, but operations marked as supported in our documentation.

Solution: Implement appropriate extractors.

Ticket: 57109

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR
  • Transformation preserves original framework node names

Validation:

  • Unit tests: N/A - implemented only extractor;
  • Framework operation tests: N/A;
  • Transformation tests: N/A - No new implemented transformations;
  • Model Optimizer IR Reader check: Done manually.

Documentation:

  • Supported frameworks operations list: This operation already added to the list;
  • Supported public models list: N/A - Nothing to add;
  • User guide update: N/A - Nothing to update.

@achetver achetver added the category: MO Model Optimizer label May 31, 2021
@achetver achetver added this to the 2021.4 milestone May 31, 2021
@achetver achetver changed the title Add extractor for ONNX GreaterOrEqual operation [MO] Add extractor for ONNX GreaterOrEqual operation May 31, 2021
@achetver achetver changed the title [MO] Add extractor for ONNX GreaterOrEqual operation [MO] Add extractor for ONNX *OrEqual operations Jun 1, 2021
@achetver achetver requested review from a team, pavel-esir, yekruglov and popovaan and removed request for a team June 1, 2021 10:12
@achetver achetver marked this pull request as ready for review June 1, 2021 10:12
@achetver achetver requested a review from a team June 1, 2021 10:12
@lazarevevgeny lazarevevgeny enabled auto-merge (squash) June 2, 2021 05:25
@lazarevevgeny lazarevevgeny merged commit f882229 into openvinotoolkit:master Jun 2, 2021
yekruglov pushed a commit to yekruglov/openvino that referenced this pull request Jun 7, 2021
* Add extractor for ONNX GreaterOrEqual operation

* Add more extractors

* Fix extractor

Co-authored-by: achetver <[email protected]>
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
* Add extractor for ONNX GreaterOrEqual operation

* Add more extractors

* Fix extractor

Co-authored-by: achetver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: MO Model Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants