Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make stress and time tests build dependent from gflags from samples #5883

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Make stress and time tests build dependent from gflags from samples #5883

merged 2 commits into from
Jun 4, 2021

Conversation

vurusovs
Copy link
Contributor

@vurusovs vurusovs commented May 28, 2021 •
edited
Loading

Original issue:

Stress and Time tests are suffered from sporadic issues caused by fail on building of gflags_nothreads_shared. Possible rootcause is a network issue while downloading gflags sources via cmake FetchContent. With aim to resolve that rootcause and unify gflags source for OpenVINO, gflags will be consumed as OpenVINO git submodule

Details:

  • Time tests now based on IEDevScripts. InferenceEngineDeveloperPackage dependency left in order to provide backward compatibility
  • Stress tests based on InferenceEngineDeveloperPackage because it requires gtest from IE tests

Tickets:

  • 55465

@vurusovs vurusovs requested a review from asomsiko May 28, 2021 11:02
@vurusovs vurusovs requested review from a team and just-sparta May 28, 2021 11:02
@openvino-pushbot openvino-pushbot added the category: IE Tests OpenVINO Test: plugins and common label May 28, 2021
@vurusovs vurusovs force-pushed the vu/improve_time_n_stress_build branch from bddeea2 to 3e7dc4b Compare May 28, 2021 11:11
@ilya-lavrenov ilya-lavrenov enabled auto-merge (squash) May 28, 2021 11:40
@vurusovs vurusovs force-pushed the vu/improve_time_n_stress_build branch 3 times, most recently from b0c6385 to 8b55f31 Compare May 31, 2021 13:37
asomsiko
asomsiko suggested changes May 31, 2021
View reviewed changes
Copy link
Contributor

@asomsiko asomsiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. PR description is invalid - "independent" vs "dependent".

  2. What problem this PR solves?

  3. Are build steps in README.md still valid?

  4. Can tests be built on installed OpenVINO?

@vurusovs vurusovs force-pushed the vu/improve_time_n_stress_build branch from 8b55f31 to 5447bd9 Compare June 1, 2021 08:36
@vurusovs vurusovs force-pushed the vu/improve_time_n_stress_build branch from 5447bd9 to 21310e1 Compare June 1, 2021 09:41
@vurusovs vurusovs requested a review from a team as a code owner June 1, 2021 09:41
@vurusovs vurusovs force-pushed the vu/improve_time_n_stress_build branch from 21310e1 to 8c5acb2 Compare June 1, 2021 09:44
@vurusovs vurusovs changed the title Make stress and time tests build independent from gflags from samples Make stress and time tests build dependent from gflags from samples Jun 1, 2021
@vurusovs
Copy link
Contributor Author

vurusovs commented Jun 1, 2021 •
edited
Loading

  1. PR description is invalid - "independent" vs "dependent".
  2. What problem this PR solves?
  3. Are build steps in README.md still valid?
  4. Can tests be built on installed OpenVINO?
  1. Fixed
  2. Added in description
  3. Steps are updated. It still valid, but extended with new option
  4. It works fine

@vurusovs vurusovs requested a review from asomsiko June 1, 2021 10:18
@vurusovs vurusovs force-pushed the vu/improve_time_n_stress_build branch 2 times, most recently from ecfc703 to 24eddd3 Compare June 2, 2021 09:58
@vurusovs vurusovs requested a review from a team June 2, 2021 09:58
@vurusovs vurusovs disabled auto-merge June 2, 2021 10:33
@vurusovs vurusovs force-pushed the vu/improve_time_n_stress_build branch from 24eddd3 to 65fe34e Compare June 2, 2021 12:54
@vurusovs vurusovs force-pushed the vu/improve_time_n_stress_build branch from 65fe34e to ee7c011 Compare June 3, 2021 12:24
@vurusovs vurusovs requested a review from ilya-lavrenov June 3, 2021 23:27
@vurusovs vurusovs enabled auto-merge (squash) June 4, 2021 07:03
@vurusovs vurusovs merged commit 291a80c into openvinotoolkit:master Jun 4, 2021
yekruglov pushed a commit to yekruglov/openvino that referenced this pull request Jun 7, 2021
@vurusovs @yekruglov
Make stress and time tests build dependent from gflags from samples (o…
8aa0e9a 
…penvinotoolkit#5883)

* Make timetests dependent on IE gflags 3rdparty from samples/

* Make stress tests dependent on IE gflags 3rdparty from samples/
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
@vurusovs
Make stress and time tests build dependent from gflags from samples (o…
0f5524e 
…penvinotoolkit#5883)

* Make timetests dependent on IE gflags 3rdparty from samples/

* Make stress tests dependent on IE gflags 3rdparty from samples/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomsiko asomsiko asomsiko approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@just-sparta just-sparta Awaiting requested review from just-sparta

Assignees

@ilya-lavrenov ilya-lavrenov

Labels
category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vurusovs @ilya-lavrenov @asomsiko @openvino-pushbot