ie_precision: added FloatTrait to fix VS2015 client compilation #5810
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR #5654
Details:
Our VS2015 build has failed due to some unsupported template constructs:
I understand that VS2015 is quite old and is not officially supported by OpenVINO, but since the fix is not too complex, I hope it won't break anything and can be accepted.
This patch is more naive version of the original code and I hope someone can propose better and more elegant solution in review comments. Other idea was to extend
PrecisionTrait
with something likeis_float
field or method, seemingly more extensive this change can simplify the code as a whole by omittingis_floating
function completly.cc @apertovs @ilya-lavrenov @alalek