Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] Fix RegionYolo (v3) node and Ngraph reference implementations #5748

Merged
merged 3 commits into from
May 26, 2021
Merged

[CPU] Fix RegionYolo (v3) node and Ngraph reference implementations #5748

merged 3 commits into from
May 26, 2021

Conversation

EgorDuplensky
Copy link
Contributor

Details:

  • Destination size was calculated incorrectly for v3 versions

Tickets:

@EgorDuplensky EgorDuplensky requested review from a team May 21, 2021 19:48
@openvino-pushbot openvino-pushbot added category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common category: Core OpenVINO Core (aka ngraph) labels May 21, 2021
@EgorDuplensky
Copy link
Contributor Author

RegionYolo description

dmitry-gorokhov
dmitry-gorokhov approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@dmitry-gorokhov dmitry-gorokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPU part lgtm

@dmitry-gorokhov
Copy link
Contributor

@lazarevevgeny could you please review ngraph reference changes? thanks

@dmitry-gorokhov dmitry-gorokhov added this to the 2021.4 milestone May 24, 2021
lazarevevgeny
lazarevevgeny approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@lazarevevgeny lazarevevgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update in output size calculation is correct.

But I want to see more test to check that output values are calculated correctly.

@EgorDuplensky
Copy link
Contributor Author

Rebasing

@EgorDuplensky EgorDuplensky force-pushed the mxnet_yolov3_issue branch 2 times, most recently from 07ee116 to 8b6229e Compare May 25, 2021 16:44
@EgorDuplensky
Copy link
Contributor Author

@dmitry-gorokhov Rebased, CI passed and the change approved by Ngraph team. Ready to be merged.

@dmitry-gorokhov dmitry-gorokhov merged commit e754a6b into openvinotoolkit:master May 26, 2021
AlexeyLebedev1 pushed a commit to AlexeyLebedev1/openvino that referenced this pull request May 27, 2021
@EgorDuplensky
[CPU] Fix RegionYolo (v3) node and Ngraph reference implementations (o…
5c807c4 
…penvinotoolkit#5748)
yekruglov pushed a commit to yekruglov/openvino that referenced this pull request Jun 7, 2021
@EgorDuplensky @yekruglov
[CPU] Fix RegionYolo (v3) node and Ngraph reference implementations (o…
1e53b9d 
…penvinotoolkit#5748)
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
@EgorDuplensky
[CPU] Fix RegionYolo (v3) node and Ngraph reference implementations (o…
d352039 
…penvinotoolkit#5748)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyachur ilyachur ilyachur left review comments

@lazarevevgeny lazarevevgeny lazarevevgeny approved these changes

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels
category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Milestone
2021.4
Development

Successfully merging this pull request may close these issues.
6 participants
@EgorDuplensky @dmitry-gorokhov @ilyachur @lazarevevgeny @maxnick @openvino-pushbot