Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IE PYTHON] FIX InputInfoCPtr, DataPtr and CDataPtr deallocation #5730

Merged
merged 3 commits into from
May 31, 2021
Merged

[IE PYTHON] FIX InputInfoCPtr, DataPtr and CDataPtr deallocation #5730

merged 3 commits into from
May 31, 2021

Conversation

AlexeyLebedev1
Copy link
Contributor

@AlexeyLebedev1 AlexeyLebedev1 commented May 20, 2021 •
edited
Loading

Details:

  • InputInfo and Data created in the Plugin should deallocate before deleting the Plugin
  • A shared pointer to the ExecutableNetwork that holds the plugin is bound to InputInfoCPtr, DataPtr and CDataPtr

Tickets:

  • 28996

@AlexeyLebedev1 AlexeyLebedev1 requested a review from a team May 20, 2021 17:38
@openvino-pushbot openvino-pushbot added the category: Python API OpenVINO Python bindings label May 20, 2021
@ilya-lavrenov ilya-lavrenov added the pr: needs tests PR needs tests updating label May 20, 2021
@ilya-lavrenov ilya-lavrenov added this to the 2021.4 milestone May 20, 2021
@akuporos akuporos requested a review from nkogteva May 20, 2021 18:26
@ilya-lavrenov
Copy link
Contributor

@AlexeyLebedev1 could you please add tests?

@AlexeyLebedev1 AlexeyLebedev1 force-pushed the alexeyl1/ie_python/fix_input_info_and_data_deallocation branch from ba40ee7 to 15e6713 Compare May 25, 2021 14:58
@ilya-lavrenov ilya-lavrenov mentioned this pull request May 26, 2021
Merged
@akuporos akuporos added bug Something isn't working and removed pr: needs tests PR needs tests updating labels May 27, 2021
@AlexeyLebedev1 AlexeyLebedev1 requested a review from a team May 27, 2021 13:42
@AlexeyLebedev1 AlexeyLebedev1 requested a review from a team as a code owner May 27, 2021 13:42
@AlexeyLebedev1 AlexeyLebedev1 requested review from a team May 27, 2021 13:42
@AlexeyLebedev1 AlexeyLebedev1 requested review from a team as code owners May 27, 2021 13:42
@AlexeyLebedev1 AlexeyLebedev1 requested review from a team May 27, 2021 13:42
@AlexeyLebedev1 AlexeyLebedev1 requested a review from a team as a code owner May 27, 2021 13:42
@AlexeyLebedev1 AlexeyLebedev1 requested a review from a team May 27, 2021 13:42
@AlexeyLebedev1 AlexeyLebedev1 requested review from a team and removed request for a team, ilyachur and GlebKazantaev May 27, 2021 13:42
@AlexeyLebedev1 AlexeyLebedev1 force-pushed the alexeyl1/ie_python/fix_input_info_and_data_deallocation branch from 152fb2c to bfc71af Compare May 27, 2021 14:03
@AlexeyLebedev1 AlexeyLebedev1 force-pushed the alexeyl1/ie_python/fix_input_info_and_data_deallocation branch from bfc71af to 8a920be Compare May 27, 2021 14:22
@nkogteva nkogteva assigned akuporos and unassigned nkogteva May 28, 2021
@ilya-lavrenov ilya-lavrenov merged commit 69b052c into openvinotoolkit:master May 31, 2021
yekruglov pushed a commit to yekruglov/openvino that referenced this pull request Jun 7, 2021
@yekruglov
[IE PYTHON] FIX InputInfoCPtr, DataPtr and CDataPtr deallocation (ope…
5b85b0a 
…nvinotoolkit#5730)

* linked ExecutableNetwork to InputInfo and Data

* Add tests

* Skip test_exec_graph_info_deallocation on ARM plugin
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
[IE PYTHON] FIX InputInfoCPtr, DataPtr and CDataPtr deallocation (ope…
705c12b 
…nvinotoolkit#5730)

* linked ExecutableNetwork to InputInfo and Data

* Add tests

* Skip test_exec_graph_info_deallocation on ARM plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuporos akuporos akuporos approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@nkogteva nkogteva Awaiting requested review from nkogteva

Assignees

@akuporos akuporos

Labels
bug Something isn't working category: Python API OpenVINO Python bindings
Projects
None yet
Milestone
2021.4
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexeyLebedev1 @ilya-lavrenov @akuporos @nkogteva @openvino-pushbot