Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make order of port names determined in IR #5701

Merged

Conversation

rkazants
Copy link
Contributor

@rkazants rkazants commented May 19, 2021

Root cause analysis: IR can be generated with undetermined order of output port names on different machines. It leads to failure during IR comparison check. Investigation showed that get_tensor_names can return port names in undetermined order due to use of set structure in one of auxiliary functions.

Solution: Make get_tensor_names generating port names in determined order (alphabetically sorted). We also considered
a way to fix IR comparator to be invariant to port names order but it requires more effort or even to switch off ports attribute check. We decided to stop on the first solution.

Ticket: 55894

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR
  • Transformation preserves original framework node names

Validation:

  • Unit tests
  • Framework operation tests
  • Transformation tests
  • Model Optimizer IR Reader check

Documentation:

  • Supported frameworks operations list
  • Guide on how to convert the public model
  • User guide update

@rkazants rkazants requested a review from a team May 19, 2021 15:35
@openvino-pushbot openvino-pushbot added the category: MO Model Optimizer label May 19, 2021
@rkazants rkazants requested review from a team, pavel-esir, vgavrilo and popovaan and removed request for a team May 20, 2021 08:07
@rkazants rkazants requested a review from lazarevevgeny May 20, 2021 08:18
@lazarevevgeny lazarevevgeny enabled auto-merge (squash) May 20, 2021 10:34
@lazarevevgeny lazarevevgeny merged commit d98e954 into openvinotoolkit:master May 20, 2021
yekruglov pushed a commit to yekruglov/openvino that referenced this pull request Jun 7, 2021
* Make order of port names determined in IR

Signed-off-by: Roman Kazantsev <[email protected]>

* Make port names in determined order and adopted tests

Signed-off-by: Roman Kazantsev <[email protected]>
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
* Make order of port names determined in IR

Signed-off-by: Roman Kazantsev <[email protected]>

* Make port names in determined order and adopted tests

Signed-off-by: Roman Kazantsev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: MO Model Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants