-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix security issue with XML parsing #5686
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvafin
force-pushed
the
fix/xml-issue
branch
4 times, most recently
from
May 20, 2021 19:42
4bb9bbe
to
e1a0ca8
Compare
rkazants
reviewed
May 21, 2021
rkazants
reviewed
May 21, 2021
rkazants
reviewed
May 21, 2021
rkazants
reviewed
May 24, 2021
rkazants
reviewed
May 24, 2021
rkazants
reviewed
May 24, 2021
rkazants
approved these changes
May 25, 2021
achetver
approved these changes
May 25, 2021
evolosen
approved these changes
May 25, 2021
lazarevevgeny
approved these changes
May 25, 2021
apankratovantonp
pushed a commit
to apankratovantonp/openvino
that referenced
this pull request
May 26, 2021
* Fix security issue with XML parsing * Apply review feedback * Rework defusing stdlib solution * Apply review feedback
AlexeyLebedev1
pushed a commit
to AlexeyLebedev1/openvino
that referenced
this pull request
May 27, 2021
* Fix security issue with XML parsing * Apply review feedback * Rework defusing stdlib solution * Apply review feedback
yekruglov
pushed a commit
to yekruglov/openvino
that referenced
this pull request
Jun 7, 2021
* Fix security issue with XML parsing * Apply review feedback * Rework defusing stdlib solution * Apply review feedback
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
* Fix security issue with XML parsing * Apply review feedback * Rework defusing stdlib solution * Apply review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause analysis:
xml.etree.ElementTree.parse
is unsafe to use,xml.etree.ElementTree
is unsafe to include.Solution: Replace unsafe
xml.etree.ElementTree.parse
with safedefusedxml.ElementTree.parse
. Usedefusedxml.defuse_sdtlib()
to patchxml.etree.ElementTree
and use objects from patched library.Ticket: 55711
Code:
Validation:
Documentation: