Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX Editor] Use port indices instead of tensor names, new naming convention of inputs #5668

Merged
merged 47 commits into from
May 21, 2021

Conversation

mbencer
Copy link
Contributor

@mbencer mbencer commented May 18, 2021

Ticket: 52743, 54016, 54933

  • Introduced a new method of edge indication - by node index and input/output port index instead of node index and tensor name
  • Changed way of creating new inputs: in general: cutting one edge causes the creation of new input (in general)
  • Introduced a new naming convention for new inputs:
    -> the original name of an input tensor, if the tensor is consumed by only a one node
    -> first output name of an input tensor consumer + "/placeholder_port_" + port_index, if the tensor is consumed by more than one node (compatible with MO)
  • Introduce a mechanism to provide custom input names

The review of this change was started in mbencer#3

mbencer and others added 30 commits March 24, 2021 11:18
Co-authored-by: Michał Karzyński <[email protected]>
@mbencer mbencer added this to the 2021.4 milestone May 18, 2021
@mbencer mbencer self-assigned this May 18, 2021
@mbencer mbencer requested a review from a team May 18, 2021 07:33
@openvino-pushbot openvino-pushbot added the category: Core OpenVINO Core (aka ngraph) label May 18, 2021
@postrational postrational merged commit 3dc1d7f into openvinotoolkit:master May 21, 2021
yekruglov pushed a commit to yekruglov/openvino that referenced this pull request Jun 7, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
@mbencer mbencer deleted the mbencer/EditorUsePortIdx branch March 2, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants