Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] ArgMin/ArgMax support for select_last_index #5661

Merged
merged 14 commits into from
May 25, 2021

Conversation

jiwaszki
Copy link

Details:

  • Added support for attribute select_last_index
  • Added Reverse to opset7

Tickets:

  • 46765

@jiwaszki jiwaszki self-assigned this May 17, 2021
@jiwaszki jiwaszki requested a review from a team May 17, 2021 14:58
@openvino-pushbot openvino-pushbot added the category: Core OpenVINO Core (aka ngraph) label May 17, 2021
@jiwaszki jiwaszki force-pushed the jiwaszki/arg_min_max branch from d11e31d to 9b5ca87 Compare May 17, 2021 20:44
@jiwaszki jiwaszki requested a review from t-jankowski May 19, 2021 11:51
@jiwaszki jiwaszki requested review from tsocha and lazarevevgeny May 19, 2021 12:04
@lazarevevgeny lazarevevgeny merged commit c3ca8d0 into openvinotoolkit:master May 25, 2021
AlexeyLebedev1 pushed a commit to AlexeyLebedev1/openvino that referenced this pull request May 27, 2021
)

* Add Reverse Op to opset

* Worksave with Reverse path

* Add last_index support

* refactor argminmax factory

* Remove old xfail, add new one

* Fix proto file for argmax

* Rewrite test for select_last_index

* Add CPU tests to Manifest

* Update manifest

* Remove Reverse from opset7

* Refactor arg_min_max factory

* Added example comment in arg_min_max

* Codestyle changes
@jiwaszki jiwaszki deleted the jiwaszki/arg_min_max branch May 31, 2021 08:15
yekruglov pushed a commit to yekruglov/openvino that referenced this pull request Jun 7, 2021
)

* Add Reverse Op to opset

* Worksave with Reverse path

* Add last_index support

* refactor argminmax factory

* Remove old xfail, add new one

* Fix proto file for argmax

* Rewrite test for select_last_index

* Add CPU tests to Manifest

* Update manifest

* Remove Reverse from opset7

* Refactor arg_min_max factory

* Added example comment in arg_min_max

* Codestyle changes
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
)

* Add Reverse Op to opset

* Worksave with Reverse path

* Add last_index support

* refactor argminmax factory

* Remove old xfail, add new one

* Fix proto file for argmax

* Rewrite test for select_last_index

* Add CPU tests to Manifest

* Update manifest

* Remove Reverse from opset7

* Refactor arg_min_max factory

* Added example comment in arg_min_max

* Codestyle changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants