-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated condition in metadata depersonalize function #5655
Merged
lazarevevgeny
merged 7 commits into
openvinotoolkit:master
from
yekruglov:metadata_fixes
May 21, 2021
Merged
Updated condition in metadata depersonalize function #5655
lazarevevgeny
merged 7 commits into
openvinotoolkit:master
from
yekruglov:metadata_fixes
May 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yekruglov
changed the title
updated condition in metadata depersonalize function
Updated condition in metadata depersonalize function
May 17, 2021
yekruglov
requested review from
a team,
mvafin,
rkazants and
popovaan
and removed request for
a team
May 18, 2021 06:48
popovaan
reviewed
May 18, 2021
popovaan
approved these changes
May 18, 2021
rkazants
reviewed
May 18, 2021
rkazants
approved these changes
May 21, 2021
lazarevevgeny
approved these changes
May 21, 2021
yekruglov
added a commit
to yekruglov/openvino
that referenced
this pull request
Jun 7, 2021
…#5655) * updated condition in metadata depersonalize function * renamed list with keys * removed unnecessary key
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
…#5655) * updated condition in metadata depersonalize function * renamed list with keys * removed unnecessary key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause analysis: The bug is reproducible, when we try to convert a model, for example, with
--data_type FP32
and--output_dir FP32
. In this case, a folder with name FP32 will be created in MO root directory. So because of that MO interprets data_type value like directory and savesdata_type
asDIR
in IR metadata. It happens, becausedepersonalize
function uses only values of input arguments while recording metadata.Solution: Create a list with MO input arguments to be marked as a directory in metadata and use it in
depersonalize
function conditionsTicket: 54298
Code:
Validation:
Documentation: