Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated condition in metadata depersonalize function #5655

Merged
merged 7 commits into from
May 21, 2021

Conversation

yekruglov
Copy link
Contributor

@yekruglov yekruglov commented May 17, 2021

Root cause analysis: The bug is reproducible, when we try to convert a model, for example, with --data_type FP32 and --output_dir FP32. In this case, a folder with name FP32 will be created in MO root directory. So because of that MO interprets data_type value like directory and saves data_type as DIR in IR metadata. It happens, because depersonalize function uses only values of input arguments while recording metadata.

Solution: Create a list with MO input arguments to be marked as a directory in metadata and use it in depersonalize function conditions

Ticket: 54298

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR
  • Transformation preserves original framework node names

Validation:

  • Unit tests N/A: can not be tested
  • Framework operation tests
  • Transformation tests
  • Model Optimizer IR Reader check

Documentation:

  • Supported frameworks operations list N/A: no new operations were enabled
  • Guide on how to convert the public model N/A: no new models were enabled
  • User guide update N/A

@yekruglov yekruglov added bug Something isn't working category: MO Model Optimizer labels May 17, 2021
@yekruglov yekruglov added this to the 2021.4 milestone May 17, 2021
@yekruglov yekruglov requested a review from a team May 17, 2021 11:25
@yekruglov yekruglov changed the title updated condition in metadata depersonalize function Updated condition in metadata depersonalize function May 17, 2021
@yekruglov yekruglov requested review from a team, mvafin, rkazants and popovaan and removed request for a team May 18, 2021 06:48
@lazarevevgeny lazarevevgeny enabled auto-merge (squash) May 21, 2021 12:47
@lazarevevgeny lazarevevgeny merged commit 40c5d11 into openvinotoolkit:master May 21, 2021
yekruglov added a commit to yekruglov/openvino that referenced this pull request Jun 7, 2021
…#5655)

* updated condition in metadata depersonalize function

* renamed list with keys

* removed unnecessary key
@yekruglov yekruglov deleted the metadata_fixes branch August 24, 2021 10:24
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
…#5655)

* updated condition in metadata depersonalize function

* renamed list with keys

* removed unnecessary key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working category: MO Model Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants