Added MVN fusion for case with constants inside #5644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-sidorova
force-pushed
the
feature/mvn_fusion
branch
from
29fb604 to
15ffe41
Compare
|
@GlebKazantaev @ilyachur take a look on ngraph part one more time please On last time after PR#5414 there were incorrect MVN fusion with eltwise for 1D and 2D cases. I transferred |
ilyachur
approved these changes
May 17, 2021
chenhu-wang
requested changes
May 17, 2021
inference-engine/tests/functional/shared_test_classes/src/subgraph/mvn_multiply_add.cpp
Show resolved
Hide resolved
dmitry-gorokhov
added
category: CPU
chenhu-wang
approved these changes
May 17, 2021
inference-engine/tests/functional/shared_test_classes/src/subgraph/mvn_multiply_add.cpp
Show resolved
Hide resolved
chenhu-wang
reviewed
May 18, 2021
...ngine/tests/functional/plugin/cpu/shared_tests_instances/subgraph_tests/mvn_multiply_add.cpp
Outdated
Show resolved
Hide resolved
a-sidorova
force-pushed
the
feature/mvn_fusion
branch
from
68aaacd to
e30dd22
Compare
[CPU] Fixed MVN [IE TESTS] Added subgraph tests for MVN and simple operations
a-sidorova
force-pushed
the
feature/mvn_fusion
branch
from
e30dd22 to
48ddf11
Compare
|
@a-sidorova Is everything finished here? |
|
@dmitry-gorokhov yes |
dmitry-gorokhov
approved these changes
May 21, 2021
yekruglov
pushed a commit
to yekruglov/openvino
that referenced
this pull request
Jun 7, 2021
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
createPrimitivebecause node initializing is beforeCommonOptimizationinMKLDNNGraph. So when we changed parameteracross_channelsin MVN ctor in methodtranformTo5DCasefor 1D and 2D shapes, there were incorrect result of condition in fusing MVN and eltwise nodes (betaandgamma) inFuseMVNAndSimpleOperationsTickets: