Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU] Subgraph tests for MulAdd and EltwiseSimple optimizations confl… #5622

Merged

Conversation

nshchego
Copy link
Contributor

Details:

3 subgraph tests on issues observed during fixing # 54941

Tickets:

54941

@nshchego nshchego requested review from a team May 13, 2021 13:19
@openvino-pushbot openvino-pushbot added category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common labels May 13, 2021
@ilya-lavrenov
Copy link
Contributor

why these tests are not a part of common IE tests classes for plugins?

CC @iefode

@ilya-lavrenov ilya-lavrenov requested a review from iefode May 14, 2021 06:32
@nshchego nshchego force-pushed the cpu/muladd_ewsimple_tests branch from 182297d to 7237fda Compare May 14, 2021 10:19
@iefode
Copy link
Contributor

iefode commented May 14, 2021

why these tests are not a part of common IE tests classes for plugins?

CC @iefode

@nshchego To be honest, I don't see any CPU plugin specific and reasons why these tests must be in CPU only. Could you please explain the situation?

@nshchego
Copy link
Contributor Author

why these tests are not a part of common IE tests classes for plugins?
CC @iefode

@nshchego To be honest, I don't see any CPU plugin specific and reasons why these tests must be in CPU only. Could you please explain the situation?

There are specific optimizations sequence in CPU plug-in. They are sensitive to eltwises and ports order. That is kind of restriction and other plugins may not have such. To be honest, these tests should also check optimized graph, but accuracy validation is enough for now.

@nshchego nshchego force-pushed the cpu/muladd_ewsimple_tests branch from 7237fda to 7a7389e Compare May 17, 2021 08:55
@nshchego nshchego force-pushed the cpu/muladd_ewsimple_tests branch from 7a7389e to 78a3c62 Compare May 20, 2021 16:26
@dmitry-gorokhov dmitry-gorokhov merged commit 19ba314 into openvinotoolkit:master May 20, 2021
yekruglov pushed a commit to yekruglov/openvino that referenced this pull request Jun 7, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants