Revise floor #5618
Merged
Revise floor #5618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mitruska can you have a look at this PR ? |
mitruska
reviewed
May 17, 2021
There was a problem hiding this comment.
So in general, the current changes in this PR cover instantiation of type prop tests (common for unary ops) and attribute visitor test (see review comments).
But if this PR and review should cover all of the revision subtasks there is some possible improvements like:
- Replace
const NodeTypeInfo& get_type_info() const override { return type_info; }byNGRAPH_RTTImacro
ngraph/op/floor.hpp#L19-L20 - Check/Refactor Floor backend tests backend/floor.in.cpp (integer tests are excluded in ie unit_test.manifest, is that still needed?)
- Floor_1.md spec refactoring (as a separate PR) for example moving the math formula to the detailed description section.
@mitruska This test still fails on CPU, so I guess it should not be removed from manifest |
mitruska
reviewed
May 18, 2021
mitruska
reviewed
May 18, 2021
mitruska
approved these changes
May 18, 2021
ilyachur
reviewed
May 19, 2021
jdanieck
approved these changes
May 20, 2021
ilyachur
approved these changes
May 21, 2021
yekruglov
pushed a commit
to yekruglov/openvino
that referenced
this pull request
Jun 7, 2021
* create type_prop tests * add visitors test * fix bug in visitor test * add RTTI macro * fix bug in visitors test * add newline * update spec * update spec * update RTTI definition * move RTTI definitioion to the top of he file * Remove broadcast from attribute tests. * Add Floor-1 to summarize.py report. Co-authored-by: jdanieck <[email protected]>
Merged
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
* create type_prop tests * add visitors test * fix bug in visitor test * add RTTI macro * fix bug in visitors test * add newline * update spec * update spec * update RTTI definition * move RTTI definitioion to the top of he file * Remove broadcast from attribute tests. * Add Floor-1 to summarize.py report. Co-authored-by: jdanieck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: