[CPU] Deconvolution int8 support #5565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonvor
force-pushed
the
feature/deconvolution_int8_support_ngraph
branch
from
edfcf24 to
e065229
Compare
antonvor
force-pushed
the
feature/deconvolution_int8_support_ngraph
branch
7 times, most recently
from
7f24007 to
f8aa9bb
Compare
antonvor
changed the title
antonvor
force-pushed
the
feature/deconvolution_int8_support_ngraph
branch
2 times, most recently
from
a77552c to
68d504d
Compare
antonvor
changed the title
maxnick
requested changes
May 18, 2021
inference-engine/src/mkldnn_plugin/nodes/mkldnn_deconv_node.cpp
Outdated
Show resolved
Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_deconv_node.cpp
Outdated
Show resolved
Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_deconv_node.cpp
Outdated
Show resolved
Hide resolved
antonvor
force-pushed
the
feature/deconvolution_int8_support_ngraph
branch
from
7666d1e to
10b6265
Compare
|
@maxnick thanks for your review! |
maxnick
approved these changes
May 20, 2021
| @@ -37,6 +40,9 @@ bool MKLDNNDeconvolutionNode::isSupportedOperation(const std::shared_ptr<ngraph: | |||
|
|
|||
| MKLDNNDeconvolutionNode::MKLDNNDeconvolutionNode(const std::shared_ptr<ngraph::Node>& op, | |||
| const mkldnn::engine& eng, MKLDNNWeightsSharing::Ptr &cache) : MKLDNNNode(op, eng, cache) { | |||
| internalBlobDesc.emplace_back([&](primitive_desc_iterator &primitive_desc_it, size_t idx) -> MKLDNNMemoryDesc { | |||
There was a problem hiding this comment.
Shouldn't we create internal desc only in case int8 execution?
| InferenceEngine::Blob::Ptr MKLDNNDeconvolutionNode::createWeiBlobAsIO(InferenceEngine::SizeVector dims) { | ||
| auto constNode = std::dynamic_pointer_cast<MKLDNNInputNode>(getParentEdgeAt(1)->getParent()); | ||
| if (!constNode) | ||
| IE_THROW() << "Cannot cast const input node for node " << getName() << "."; |
There was a problem hiding this comment.
The plugin will throw an exception in case canBeExecutedInInt8() returns true but we weights input is not const node (for example in case we have reshape on weights branch). I would suggest to update canBeExecutedInInt8() with this condition.
dmitry-gorokhov
approved these changes
May 21, 2021
yekruglov
pushed a commit
to yekruglov/openvino
that referenced
this pull request
Jun 7, 2021
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets:
PR in oneDNN: openvinotoolkit/oneDNN#50
PR with tests: #5348
Builds: 624, 625
TODO