Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant copying of weights and biases for convolution layer #5551

Merged

Conversation

vladislav-volkov
Copy link
Contributor

Details:

  • Redundant copying of weights and biases removed for convolution layer.
  • Some legacy code removed from MKLDNN convolution layer

Tickets:

@vladislav-volkov vladislav-volkov requested review from a team May 7, 2021 09:17
@openvino-pushbot openvino-pushbot added the category: CPU OpenVINO CPU plugin label May 7, 2021
@vladislav-volkov vladislav-volkov force-pushed the dev-shared-consts branch 4 times, most recently from 2d8cf89 to 95fc17b Compare May 17, 2021 11:54
@dmitry-gorokhov dmitry-gorokhov added this to the 2021.4 milestone May 24, 2021
@vladislav-volkov vladislav-volkov requested a review from a team May 25, 2021 14:32
@vladislav-volkov vladislav-volkov force-pushed the dev-shared-consts branch 3 times, most recently from 73cfde9 to 10f6c7c Compare May 25, 2021 16:40
const InferenceEngine::Blob::CPtr getConstBlob() const {
return constBlob;
}
private:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: two private sections

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use private sections to separate function declarations and class members. (:

@vladislav-volkov vladislav-volkov force-pushed the dev-shared-consts branch 2 times, most recently from 8454dfa to bb30fd7 Compare May 26, 2021 11:12
@evgenytalanin-intel evgenytalanin-intel merged commit 96b7a04 into openvinotoolkit:master May 26, 2021
AlexeyLebedev1 pushed a commit to AlexeyLebedev1/openvino that referenced this pull request May 27, 2021
…notoolkit#5551)

* Using shared constants blobs in a CPU plugin

* Improvements for subnormals checking

* Review comments

* WA for unaligned FullyConnected input sizes
yekruglov pushed a commit to yekruglov/openvino that referenced this pull request Jun 7, 2021
…notoolkit#5551)

* Using shared constants blobs in a CPU plugin

* Improvements for subnormals checking

* Review comments

* WA for unaligned FullyConnected input sizes
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
…notoolkit#5551)

* Using shared constants blobs in a CPU plugin

* Improvements for subnormals checking

* Review comments

* WA for unaligned FullyConnected input sizes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants