[VPU] Batch support for interpolate #5520
Conversation
openvino-pushbot
added
category: inference
| const auto paramIsSupported = ic == oc && in == 1 && on == 1 && isPadZeros(padsBegin) && isPadZeros(padsEnd); | ||
| VPU_THROW_UNLESS(paramIsSupported, "Current Interpolate does not support paddings, batches, and resize by channels"); | ||
| const auto paramIsSupported = ic == oc && isPadZeros(padsBegin) && isPadZeros(padsEnd); | ||
| VPU_THROW_UNLESS(paramIsSupported, "Current Interpolate does not support paddings, and resize by channels"); |
There was a problem hiding this comment.
Let's split this message into 2 separate messages related to padding and channels accordingly
| {1, 8, 36, 36}, | ||
| {1, 8, 35, 35}, | ||
| {1, 8, 6, 6}, | ||
| {3, 8, 38, 38}, |
There was a problem hiding this comment.
I think we should not set batches for all test cases
| InferenceEngine::SizeVector, // Input shapes | ||
| InferenceEngine::SizeVector, // Target shapes | ||
| LayerTestsUtils::TargetDevice, // Device name | ||
| std::map<std::string, std::string> // Additional network configuration |
There was a problem hiding this comment.
I guess there is such a typedef somewhere
There was a problem hiding this comment.
Not in common files
| @@ -50,4 +63,13 @@ class InterpolateLayerTest : public testing::WithParamInterface<InterpolateLayer | |||
| void SetUp() override; | |||
| }; | |||
|
|
|||
| class InterpolateLayerTestWithConfig : public testing::WithParamInterface<InterpolateLayerTestParamsWithConfig>, | |||
There was a problem hiding this comment.
Maybe we'll leave only one test class and change instances in all plugins?
I don't like the current solution as far it causes a lot of ridiculous copy-pasta
There was a problem hiding this comment.
I did it before last commit.
But this will also require changes to the tests in the other plugins. Is is okay?
There was a problem hiding this comment.
Why not? But you will have to use product-config repo to trigger a build with corresponding branches
There was a problem hiding this comment.
Reverted changes with lots of copypasta
DariaMityagina
force-pushed
the
icv/batch_support
branch
from
d2b96f4 to
5bfe47b
Compare
|
@Maxim-Doronin @AntonDudchenko could you please approve this request if everything is okay? |
DariaMityagina
force-pushed
the
icv/batch_support
branch
2 times, most recently
from
ff1c6ad to
45bceab
Compare
DariaMityagina
force-pushed
the
icv/batch_support
branch
from
45bceab to
4a87ca2
Compare
* batch support for interpolate * hash update * compilation errors solved * changes in tests, so not to break other plugins * changes in tests, so not to break other plugins * Revert "changes in tests, so not to break other plugins" This reverts commit 67e5c1e. * Revert "changes in tests, so not to break other plugins" This reverts commit f6a537d. * review corrections * Firmware update
* batch support for interpolate * hash update * compilation errors solved * changes in tests, so not to break other plugins * changes in tests, so not to break other plugins * Revert "changes in tests, so not to break other plugins" This reverts commit 67e5c1e. * Revert "changes in tests, so not to break other plugins" This reverts commit f6a537d. * review corrections * Firmware update
Details:
Tickets: