-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuse mul transformation fix #5518
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popovaan
requested review from
a team,
pavel-esir,
iimironov and
rkazants
and removed request for
a team
May 7, 2021 08:15
rkazants
approved these changes
May 7, 2021
lazarevevgeny
approved these changes
May 7, 2021
jane-intel
pushed a commit
that referenced
this pull request
May 26, 2021
This reverts commit 84b94c9.
evgenytalanin-intel
pushed a commit
that referenced
this pull request
May 26, 2021
AlexeyLebedev1
pushed a commit
to AlexeyLebedev1/openvino
that referenced
this pull request
May 27, 2021
…toolkit#5831) This reverts commit 84b94c9.
yekruglov
pushed a commit
to yekruglov/openvino
that referenced
this pull request
Jun 7, 2021
…toolkit#5831) This reverts commit 84b94c9.
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
…toolkit#5831) This reverts commit 84b94c9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause analysis:
_fuse_add transformation finds MatMul node and a Mul node that goes after it, than removes Mul node and inserts a new Mul node before the MatMul using set_source() method. set_source() copies attributes from the data node of old connection to the new data node and it leads to appearance of two data nodes with the same name.
After the constant folding and graph cleanup the operation that goes to the new data node is deleted as const producer and the new Const op is created with the name obtained from data node which leads to the error, that graph contains two nodes with the same name.
Solution: If we use set_destination() in _fuse_add old data node is reused in previous op -> new Mul connection and attributes are not copied to new Mul-> MatMul connection.
Ticket: 54845
Code:
Validation:
Documentation: