NGraph FrontEnd Manager - Basic API #5470

nosovmik · 2021-04-29T19:56:22Z

Details:

NGraph FrontEnd Manager - Basic API
Plugin API for automatic discovery
Unit test + mock frontend

Tickets:

52321, 54372, 54803

Added Mock frontend for unit testing

ngraph/frontend/generic/src/frontend_manager.cpp

ngraph/frontend/generic/include/frontend_manager/frontend_manager.hpp

ngraph/test/frontend/CMakeLists.txt

ngraph/test/frontend/frontend_manager.cpp

ngraph/frontend/generic/include/frontend_manager/frontend_manager.hpp

ngraph/frontend/generic/include/frontend_manager/frontend_manager_defs.hpp

ngraph/frontend/generic/src/frontend_manager.cpp

ngraph/frontend/generic/src/plugin_loader.cpp

Introduced environment variable OV_FRONTEND_PATH for frontend paths

More code coverage

In case of unset or empty OV_FRONTENT_PATH - load plugins from current working directory

ngraph/CMakeLists.txt

ngraph/frontend/generic/CMakeLists.txt

ngraph/frontend/generic/include/frontend_manager/frontend_manager.hpp

Add clang format target for frontend_manager and mock frontend plugin

ngraph/frontend/frontend_manager/include/frontend_manager/frontend_manager.hpp

GlebKazantaev · 2021-05-28T11:48:56Z

Approving part that I have reviewed (everything except tests). Look like I need more details from @nosovmik or @slyalin about classes and methods purposes.

ngraph/frontend/frontend_manager/include/frontend_manager/frontend_manager.hpp

ilyachur · 2021-05-31T08:21:00Z

About frontend API, we had a long discussion with @slyalin and we need to have this PR in the master in order to unblock development of PDPD and ONNX frontends and get additional feedback from guys who will develop these frontends.
As I understand at the current moment @mvafin is developing new API to simplify read model and decrease the number of read methods in API.
And as I understood we need to review this API in the future.

Moreover I have some comments/concerns about the current API:

We need to show different cases and demonstrate which functionality should be implemented for all these cases or maybe change the granularity of classes in order to make interfaces for different scenarios more clear. We need to think about this API from the user side, which wants to contribute new frontend or reader to OpenVINO.
If we want to replace Reader API by Frontend API, we need to add a support of custom operations and other extensions.
If we merge it to the master branch, we need to double check that OV package doesn't have any files from this API.

@slyalin Please correct me if I forgot anything.

Moreover I highly recommend to split frontend_manager.hpp to several separate files.

nosovmik · 2021-05-31T11:22:45Z

Moreover I highly recommend to split frontend_manager.hpp to several separate files.

This part is done

Exposing Python API for nGraph FrontEndManager introduced in PR openvinotoolkit#5470

* NGraph - FrontEndManager - common API Added Mock frontend for unit testing * Comment out installation rules * Fixed review comment Introduced environment variable OV_FRONTEND_PATH for frontend paths * Additional cmake cleanup * More fixes of cmakelists * Changing template file name for frontends * Changed copyrights * Reuse ngraph-utils for file-related operations * Correct of frontend file extension for macos More code coverage * Renamed all methods to according to ngraph-style In case of unset or empty OV_FRONTENT_PATH - load plugins from current working directory * Fix review comments Add clang format target for frontend_manager and mock frontend plugin * Update docs for FrontEndCapabilities * Use constants for flags instead of 'enum' * clang style fix * Fix comment: using namespace ngraph... * Fix comment: use replace "frontend_manager" with ${TARGET_NAME} in CMakeLists.txt * Comment fix: rename 'generic' folder to 'frontend_manager' * Update documentation comments * Set FrontEndManager class as 'final' * Apply review comments * renamed get_place_by_name_and... to get_place_by_operation_name_and... * Separated frontend_manager.hpp into 4 header files

* [NG Frontend] Introduce classes and macros for Frontend-specific exceptions * [nGraph Frontend] Python bindings Exposing Python API for nGraph FrontEndManager introduced in PR #5470 * [nGraph Frontend] Python bindings Exposing Python API for nGraph FrontEndManager introduced in PR #5470 * Added docs + moved sources to 'pyngraph/frontend' * Fix issues after rebase * Fix clang * Moving ngraph/python/tests_cpp to ngraph/python/tests/mock * Fix cmakelists-related comments * Apply review comments * Added dots to docstrings * Cmake - Set target properties for ARCHIVE/PDB/COMPILE_PDB as well as for LIBRARY_OUTPUT_DIRECTORY

* [NG Frontend] Introduce classes and macros for Frontend-specific exceptions * [nGraph Frontend] Python bindings Exposing Python API for nGraph FrontEndManager introduced in PR #5470 * Exposing 'Dimension' class to Python nGraph API * Model optimizer code from pdpd_frontend Removed 'use_legacy_frontend' option as not needed for PDPD integration * Added XML/BIN prints for 'ngraph-FE' serialization path * Update python bindings to latest code from PR #5995 * Add OV_FRONTEND_PATH to LD_LIBRARY_PATH by default for Model Optimizer * Test with 'mock' frontend * Added meta info to generated IR Added more tests to cover currently supported scenarios Clang config for MO mock frontend * some flake8 and pylint fixes * Try to 'import' ngraph-related packages on top of python files This will help to specify type of function arguments, but can break unit tests if they're using functions directly without ngraph * CI fixes * Run tests from 'main_test.py' inside ngraph environment * Fixed review comments * Fixed comments Added more tests for checking if inputs and outputs are same * Renamed front_ng to moc_frontend * Update package_BOM.txt

* NGraph - FrontEndManager - common API Added Mock frontend for unit testing * Comment out installation rules * Fixed review comment Introduced environment variable OV_FRONTEND_PATH for frontend paths * Additional cmake cleanup * More fixes of cmakelists * Changing template file name for frontends * Changed copyrights * Reuse ngraph-utils for file-related operations * Correct of frontend file extension for macos More code coverage * Renamed all methods to according to ngraph-style In case of unset or empty OV_FRONTENT_PATH - load plugins from current working directory * Fix review comments Add clang format target for frontend_manager and mock frontend plugin * Update docs for FrontEndCapabilities * Use constants for flags instead of 'enum' * clang style fix * Fix comment: using namespace ngraph... * Fix comment: use replace "frontend_manager" with ${TARGET_NAME} in CMakeLists.txt * Comment fix: rename 'generic' folder to 'frontend_manager' * Update documentation comments * Set FrontEndManager class as 'final' * Apply review comments * renamed get_place_by_name_and... to get_place_by_operation_name_and... * Separated frontend_manager.hpp into 4 header files

…oolkit#5995) * [NG Frontend] Introduce classes and macros for Frontend-specific exceptions * [nGraph Frontend] Python bindings Exposing Python API for nGraph FrontEndManager introduced in PR openvinotoolkit#5470 * [nGraph Frontend] Python bindings Exposing Python API for nGraph FrontEndManager introduced in PR openvinotoolkit#5470 * Added docs + moved sources to 'pyngraph/frontend' * Fix issues after rebase * Fix clang * Moving ngraph/python/tests_cpp to ngraph/python/tests/mock * Fix cmakelists-related comments * Apply review comments * Added dots to docstrings * Cmake - Set target properties for ARCHIVE/PDB/COMPILE_PDB as well as for LIBRARY_OUTPUT_DIRECTORY

* [NG Frontend] Introduce classes and macros for Frontend-specific exceptions * [nGraph Frontend] Python bindings Exposing Python API for nGraph FrontEndManager introduced in PR openvinotoolkit#5470 * Exposing 'Dimension' class to Python nGraph API * Model optimizer code from pdpd_frontend Removed 'use_legacy_frontend' option as not needed for PDPD integration * Added XML/BIN prints for 'ngraph-FE' serialization path * Update python bindings to latest code from PR openvinotoolkit#5995 * Add OV_FRONTEND_PATH to LD_LIBRARY_PATH by default for Model Optimizer * Test with 'mock' frontend * Added meta info to generated IR Added more tests to cover currently supported scenarios Clang config for MO mock frontend * some flake8 and pylint fixes * Try to 'import' ngraph-related packages on top of python files This will help to specify type of function arguments, but can break unit tests if they're using functions directly without ngraph * CI fixes * Run tests from 'main_test.py' inside ngraph environment * Fixed review comments * Fixed comments Added more tests for checking if inputs and outputs are same * Renamed front_ng to moc_frontend * Update package_BOM.txt

nosovmik requested review from mvafin, itikhono, slyalin and a team April 29, 2021 19:56

openvino-pushbot added the category: Core OpenVINO Core (aka ngraph) label Apr 29, 2021

nosovmik added 2 commits April 30, 2021 00:32

NGraph - FrontEndManager - common API

aa12ff7

Added Mock frontend for unit testing

Comment out installation rules

4ce398e

itikhono reviewed Apr 30, 2021

View reviewed changes

ilya-lavrenov reviewed Apr 30, 2021

View reviewed changes

nosovmik marked this pull request as draft April 30, 2021 11:50

nosovmik force-pushed the fe_manager branch 2 times, most recently from bc2907c to fa893d3 Compare April 30, 2021 13:00

nosovmik added 7 commits April 30, 2021 16:20

Fixed review comment

cd166a9

Introduced environment variable OV_FRONTEND_PATH for frontend paths

Additional cmake cleanup

7cde9c9

More fixes of cmakelists

90a4e2a

Changing template file name for frontends

fa893d3

Changed copyrights

718a1d0

Reuse ngraph-utils for file-related operations

8e28efd

Correct of frontend file extension for macos

36c6534

More code coverage

nosovmik marked this pull request as ready for review May 4, 2021 08:02

nosovmik requested review from ilyachur, GlebKazantaev and andrei-kochin May 4, 2021 08:03

Renamed all methods to according to ngraph-style

fc9d05c

In case of unset or empty OV_FRONTENT_PATH - load plugins from current working directory

ilyachur reviewed May 11, 2021

View reviewed changes

nosovmik force-pushed the fe_manager branch from e79d596 to 6bd62c1 Compare May 11, 2021 14:09

nosovmik added 4 commits May 11, 2021 20:16

Fix review comments

6bd62c1

Add clang format target for frontend_manager and mock frontend plugin

Update docs for FrontEndCapabilities

481ecf1

Use constants for flags instead of 'enum'

c6184ad

clang style fix

46df0b3

GlebKazantaev reviewed May 25, 2021

View reviewed changes

ngraph/frontend/frontend_manager/include/frontend_manager/frontend_manager.hpp Outdated Show resolved Hide resolved

nosovmik added 3 commits May 26, 2021 15:27

Merge remote-tracking branch 'upstream/master' into fe_manager

53df7af

Apply review comments

13f1ffa

renamed get_place_by_name_and... to get_place_by_operation_name_and...

a5396c4

ilyachur self-requested a review May 26, 2021 17:06

GlebKazantaev approved these changes May 28, 2021

View reviewed changes

ilyachur reviewed May 28, 2021

View reviewed changes

ngraph/frontend/frontend_manager/include/frontend_manager/frontend_manager.hpp Outdated Show resolved Hide resolved

ilyachur self-requested a review May 28, 2021 13:03

nosovmik added 3 commits May 31, 2021 17:19

Separated frontend_manager.hpp into 4 header files

6394240

Merge remote-tracking branch 'upstream/master' into fe_manager

0c382c2

Merge remote-tracking branch 'upstream/master' into fe_manager

93093c8

ilyachur approved these changes Jun 1, 2021

View reviewed changes

nosovmik removed the request for review from andrei-kochin June 1, 2021 15:05

andrei-kochin approved these changes Jun 1, 2021

View reviewed changes

mvafin approved these changes Jun 1, 2021

View reviewed changes

slyalin merged commit 5765a7e into openvinotoolkit:master Jun 1, 2021

ilya-lavrenov added this to the 2021.4 milestone Jun 1, 2021

nosovmik added a commit to nosovmik/openvino that referenced this pull request Jun 2, 2021

[nGraph Frontend] Python bindings

b1f7b08

Exposing Python API for nGraph FrontEndManager introduced in PR openvinotoolkit#5470

nosovmik mentioned this pull request Jun 2, 2021

[nGraph FE] Python bindings for nGraph FrontEndManager API #5995

Merged

nosovmik added a commit to nosovmik/openvino that referenced this pull request Jun 2, 2021

[nGraph Frontend] Python bindings

7d8c3e7

Exposing Python API for nGraph FrontEndManager introduced in PR openvinotoolkit#5470

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NGraph FrontEnd Manager - Basic API #5470

NGraph FrontEnd Manager - Basic API #5470

nosovmik commented Apr 29, 2021 •

edited by andrei-kochin

Loading

GlebKazantaev commented May 28, 2021 •

edited

Loading

ilyachur commented May 31, 2021

nosovmik commented May 31, 2021

NGraph FrontEnd Manager - Basic API #5470

NGraph FrontEnd Manager - Basic API #5470

Conversation

nosovmik commented Apr 29, 2021 • edited by andrei-kochin Loading

Details:

Tickets:

GlebKazantaev commented May 28, 2021 • edited Loading

ilyachur commented May 31, 2021

nosovmik commented May 31, 2021

nosovmik commented Apr 29, 2021 •

edited by andrei-kochin

Loading

GlebKazantaev commented May 28, 2021 •

edited

Loading