Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revision of Sqrt op and reference implementation #5446

Merged
merged 4 commits into from
Apr 30, 2021
Merged

Revision of Sqrt op and reference implementation #5446

merged 4 commits into from
Apr 30, 2021

Conversation

mitruska
Copy link
Contributor

@mitruska mitruska commented Apr 28, 2021 •
edited
Loading

Details:

  • Sqrt reference impl - Add rounding for integral types result (aligned with CPU)
  • Add RTTI macro
  • Add and refactor backend tests
  • Type prop tests (as unary ops)

Tickets:

  • 37482 (45931, 45933)

@mitruska mitruska added the category: Core OpenVINO Core (aka ngraph) label Apr 28, 2021
@mitruska mitruska marked this pull request as ready for review April 28, 2021 16:42
@mitruska mitruska self-assigned this Apr 28, 2021
@mitruska mitruska mentioned this pull request Apr 28, 2021
Merged
@mitruska mitruska requested a review from blesniewski April 30, 2021 06:18
@ilyachur ilyachur merged commit a7353f4 into openvinotoolkit:master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggalieroc-zz ggalieroc-zz ggalieroc-zz approved these changes

@pelszkow pelszkow pelszkow approved these changes

@blesniewski blesniewski blesniewski approved these changes

@ilyachur ilyachur ilyachur approved these changes

@lazarevevgeny lazarevevgeny Awaiting requested review from lazarevevgeny

Assignees

@mitruska mitruska

Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mitruska @ilyachur @blesniewski @pelszkow @ggalieroc-zz