-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gather-7 specification #5441
Update Gather-7 specification #5441
Conversation
@sadolini @yekruglov @iimironov @lazarevevgeny Please, review this PR with important changes in Gather-7 operation specification. |
I think that description for My suggestion is: Because otherwise the example 4 contradicts this description. |
Allowed values are from [-len(indices.shape), len(indices.shape) - 1] and axis >= batch_dims as in tensorflow |
…restriction for index types
@andrei-cv indeed there must be https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/kernels/gather_op.cc#L81-L89 |
Details:
batch_dims
attribute. Also update formula to same view as in TF specification to make it more clear.Tickets: