Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] Add bf16 support for ROI pooling #5187

Merged
merged 8 commits into from
May 25, 2021
Merged

[CPU] Add bf16 support for ROI pooling #5187

merged 8 commits into from
May 25, 2021

Conversation

EgorDuplensky
Copy link
Contributor

Details:

  • BF16 implementation is faster and helps to exclude unnecessary reorders

Tickets:

@EgorDuplensky EgorDuplensky requested review from a team April 12, 2021 08:58
@openvino-pushbot openvino-pushbot added category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common labels Apr 12, 2021
@maxnick maxnick self-assigned this Apr 12, 2021
@EgorDuplensky EgorDuplensky marked this pull request as draft April 13, 2021 06:27
@EgorDuplensky EgorDuplensky force-pushed the roi_pooling_bf16 branch 4 times, most recently from 6fff6e7 to 1d16dfb Compare April 26, 2021 19:21
@EgorDuplensky EgorDuplensky changed the title Add bf16 support for ROI pooling [CPU] Add bf16 support for ROI pooling Apr 26, 2021
@EgorDuplensky EgorDuplensky mentioned this pull request Apr 27, 2021
Merged
@EgorDuplensky
Copy link
Contributor Author

Waiting for #5432

@EgorDuplensky EgorDuplensky marked this pull request as ready for review May 4, 2021 15:39
maxnick
maxnick requested changes May 5, 2021
View reviewed changes
inference-engine/src/mkldnn_plugin/nodes/mkldnn_roi_pooling_node.cpp Outdated Show resolved Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_roi_pooling_node.cpp Outdated Show resolved Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_roi_pooling_node.cpp Outdated Show resolved Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_roi_pooling_node.cpp Outdated Show resolved Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_roi_pooling_node.cpp Outdated Show resolved Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_roi_pooling_node.cpp Outdated Show resolved Hide resolved
inference-engine/src/mkldnn_plugin/nodes/mkldnn_roi_pooling_node.cpp Outdated Show resolved Hide resolved
inference-engine/tests/functional/plugin/cpu/single_layer_tests/roi_pooling.cpp Outdated Show resolved Hide resolved
inference-engine/tests/functional/plugin/cpu/single_layer_tests/roi_pooling.cpp Outdated Show resolved Hide resolved
inference-engine/tests/functional/plugin/cpu/single_layer_tests/roi_pooling.cpp Outdated Show resolved Hide resolved
@EgorDuplensky
Copy link
Contributor Author

Rebased.
@maxnick Comments applied. Also GenerateInputs() was a bit adjusted after rebase.

maxnick
maxnick approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@maxnick maxnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM, but this two comments need to be discussed.

@EgorDuplensky
Copy link
Contributor Author

Rebased onto ngraph migration commit

@EgorDuplensky
Copy link
Contributor Author

@dmitry-gorokhov CI is fixed, could you please take a look

@EgorDuplensky
Copy link
Contributor Author

Rebased

@dmitry-gorokhov
Copy link
Contributor

Please rebase on latest master to get fresh CI

@dmitry-gorokhov dmitry-gorokhov added this to the 2021.4 milestone May 24, 2021
@EgorDuplensky
Copy link
Contributor Author

@dmitry-gorokhov Rebased

@dmitry-gorokhov dmitry-gorokhov merged commit bae7f4b into openvinotoolkit:master May 25, 2021
AlexeyLebedev1 pushed a commit to AlexeyLebedev1/openvino that referenced this pull request May 27, 2021
@EgorDuplensky
[CPU] Add bf16 support for ROI pooling (openvinotoolkit#5187)
aef7258
yekruglov pushed a commit to yekruglov/openvino that referenced this pull request Jun 7, 2021
@EgorDuplensky @yekruglov
[CPU] Add bf16 support for ROI pooling (openvinotoolkit#5187)
77e14c4
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
@EgorDuplensky
[CPU] Add bf16 support for ROI pooling (openvinotoolkit#5187)
e7eb7e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxnick maxnick maxnick approved these changes

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

@alexey-varyzgin alexey-varyzgin Awaiting requested review from alexey-varyzgin

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels
category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Milestone
2021.4
Development

Successfully merging this pull request may close these issues.
4 participants
@EgorDuplensky @dmitry-gorokhov @maxnick @openvino-pushbot