Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align MO pip requirements #5171

Merged
merged 4 commits into from
May 14, 2021
Merged

Align MO pip requirements #5171

merged 4 commits into from
May 14, 2021

Conversation

ilya-naumov
Copy link
Contributor

Details:

  • Set MO's pip dependency requirements to ~= and remove TF1

Tickets:

  • internal 48358

@openvino-pushbot openvino-pushbot added the category: MO Model Optimizer label Apr 9, 2021
@achetver achetver mentioned this pull request Apr 22, 2021
Merged
11 tasks
@lazarevevgeny lazarevevgeny requested a review from achetver April 23, 2021 10:14
@lazarevevgeny
Copy link
Contributor

@achetver , please, take a look at this PR. Does MO version checker works correctly for the updated requirements?

@achetver
Copy link
Contributor

@lazarevevgeny MO version checker in PR works correctly with ~= signs but I don't see support of sys_platform == '...' environment marker and during environment check these markers will be ignored.

@generalova-kate
Copy link
Contributor

@achetver could you add support sys_platform on this week?

@achetver
Copy link
Contributor

achetver commented Apr 26, 2021 •
edited
Loading

@generalova-kate Yes, I can. But it is necessary to use different versions of mxnet depending on platform? And why?

@ilya-naumov
Copy link
Contributor Author

@achetver Windows package of mxnet 1.7.0.post2 conflicts with numpy and requests (Windows wheels isn't available for newer versions on PyPi). We use mxnet 1.2.0 on Windows because it doesn't cause dependency conflicts on this environment and we can't use same version on Linux because it requires old numpy. You can find more info at the ticket.

@achetver achetver mentioned this pull request Apr 27, 2021
Merged
11 tasks
@lazarevevgeny
Copy link
Contributor

PR #5437 has been merged. Please, merge the recent master to your branch and re-validate again.

@azhogov azhogov merged commit 3e076a8 into openvinotoolkit:master May 14, 2021
yekruglov pushed a commit to yekruglov/openvino that referenced this pull request Jun 7, 2021
@ilya-naumov @yekruglov
Align MO pip requirements (openvinotoolkit#5171)
f85ac13 
* Align MO pip requirements

* fix missing mxnet on platforms other than Windows or Linux

* remove spaces near environment markers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achetver achetver achetver left review comments

@lazarevevgeny lazarevevgeny lazarevevgeny approved these changes

@generalova-kate generalova-kate Awaiting requested review from generalova-kate

Assignees
No one assigned
Labels
category: MO Model Optimizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ilya-naumov @lazarevevgeny @achetver @generalova-kate @azhogov @openvino-pushbot