Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU] Add Roll support #5112

Merged
merged 4 commits into from
May 3, 2021

Conversation

apertovs
Copy link
Contributor

@apertovs apertovs commented Apr 5, 2021

Tickets:

  • 49391

@apertovs apertovs requested review from nshchego and a team April 5, 2021 16:57
@openvino-pushbot openvino-pushbot added category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common labels Apr 5, 2021
@apertovs apertovs force-pushed the ap/dev/roll_op_cpu branch 2 times, most recently from c0ab191 to 7ac66a3 Compare April 19, 2021 18:44
@apertovs apertovs requested a review from a team April 19, 2021 18:44
@apertovs apertovs force-pushed the ap/dev/roll_op_cpu branch 2 times, most recently from 49d050e to bfcd18e Compare April 26, 2021 07:32
@dmitry-gorokhov
Copy link
Contributor

dmitry-gorokhov commented Apr 28, 2021

@apertovs general ask according with the latest requirements: please reimplement the node using MKLDNNNode API.

@apertovs apertovs force-pushed the ap/dev/roll_op_cpu branch from 2f7d0c5 to 793f4fa Compare April 28, 2021 18:19
@apertovs apertovs force-pushed the ap/dev/roll_op_cpu branch from 12e5706 to fc007d5 Compare April 29, 2021 17:14
@apertovs apertovs force-pushed the ap/dev/roll_op_cpu branch from fc007d5 to 1843179 Compare April 29, 2021 20:42
@dmitry-gorokhov
Copy link
Contributor

@iefode Could you please take a look on tests part?

@dmitry-gorokhov dmitry-gorokhov added this to the 2021.4 milestone Apr 30, 2021
@dmitry-gorokhov dmitry-gorokhov self-assigned this Apr 30, 2021
Directly use shape
Specifying all possible precisions
Dynbatch = false
Replace getBlob
Remove 8 bytes case for rollImpl
Add repeated axes to rollCase
@dmitry-gorokhov dmitry-gorokhov merged commit 5d8f209 into openvinotoolkit:master May 3, 2021
ilya-lavrenov added a commit to ilya-lavrenov/openvino that referenced this pull request May 4, 2021
ilya-lavrenov added a commit that referenced this pull request May 20, 2021
* Exclude xbyak from install

* Added automatically generated InferenceEngineConfig.cmake

* Reverted a version back

* Fixed issues with target aliases

* Make TBB dependency private

* Made ie_parallel.cmake self-sufficient

* Don't expose ie_paralle.cmake to end users

* Fixed compilation with TBB

* Fixes for TBB

* Fixed vpu_graph_transformer compilation

* Fixed tests compilation

* Added install of ie_parallel.cmake

* Switched ENABLE_ALTERNATIVE_TEMP to OFF. Fixed COMPONENTS for TBB

* Fixed file name in install rules

* Added find_dependency for TBB in ie_parallel.cmake

* WA for cmake bug with PACKAGE_PREFIX_DIR

* Fixed no-deprecation to fix speech-library build

* Reverted version from 2.1.0 to 2.1

* Revert "Reverted version from 2.1.0 to 2.1"

This reverts commit 7cb5d15.

* Added versions to cmake

* Added versions to ie_version.hpp

* Returned custom version file back

* Added InferenceEngineConfig-version.cmake to share as well

* Disabled one more GPU test

* Added one more WA for CI

* WA for CI issue for C API

* Added InferenceEngineConfig-version.cmake to share as well

* Added verison parsing from ie_version.hpp

* Revert "[CPU] Add Roll support (#5112)"

This reverts commit 5d8f209.

* Revert "[CPU] windows_Interpolate_fused-FQ_nearest-mode_nspc-layout_fix (#5317)"

This reverts commit 0808975.

* Revert "[INT8][BF16] INT8 + BF16 feature was enabled (#5059)"

This reverts commit 7d2ec02.

* Support for components

* No version for IEDevScripts package

* Removed IE_VS_VER_HAS_VERSION from vs_version.rc.in

* Added compatibility for 2.x old versioning
yekruglov pushed a commit to yekruglov/openvino that referenced this pull request Jun 7, 2021
* Exclude xbyak from install

* Added automatically generated InferenceEngineConfig.cmake

* Reverted a version back

* Fixed issues with target aliases

* Make TBB dependency private

* Made ie_parallel.cmake self-sufficient

* Don't expose ie_paralle.cmake to end users

* Fixed compilation with TBB

* Fixes for TBB

* Fixed vpu_graph_transformer compilation

* Fixed tests compilation

* Added install of ie_parallel.cmake

* Switched ENABLE_ALTERNATIVE_TEMP to OFF. Fixed COMPONENTS for TBB

* Fixed file name in install rules

* Added find_dependency for TBB in ie_parallel.cmake

* WA for cmake bug with PACKAGE_PREFIX_DIR

* Fixed no-deprecation to fix speech-library build

* Reverted version from 2.1.0 to 2.1

* Revert "Reverted version from 2.1.0 to 2.1"

This reverts commit 7cb5d15.

* Added versions to cmake

* Added versions to ie_version.hpp

* Returned custom version file back

* Added InferenceEngineConfig-version.cmake to share as well

* Disabled one more GPU test

* Added one more WA for CI

* WA for CI issue for C API

* Added InferenceEngineConfig-version.cmake to share as well

* Added verison parsing from ie_version.hpp

* Revert "[CPU] Add Roll support (openvinotoolkit#5112)"

This reverts commit 5d8f209.

* Revert "[CPU] windows_Interpolate_fused-FQ_nearest-mode_nspc-layout_fix (openvinotoolkit#5317)"

This reverts commit 0808975.

* Revert "[INT8][BF16] INT8 + BF16 feature was enabled (openvinotoolkit#5059)"

This reverts commit 7d2ec02.

* Support for components

* No version for IEDevScripts package

* Removed IE_VS_VER_HAS_VERSION from vs_version.rc.in

* Added compatibility for 2.x old versioning
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
* Exclude xbyak from install

* Added automatically generated InferenceEngineConfig.cmake

* Reverted a version back

* Fixed issues with target aliases

* Make TBB dependency private

* Made ie_parallel.cmake self-sufficient

* Don't expose ie_paralle.cmake to end users

* Fixed compilation with TBB

* Fixes for TBB

* Fixed vpu_graph_transformer compilation

* Fixed tests compilation

* Added install of ie_parallel.cmake

* Switched ENABLE_ALTERNATIVE_TEMP to OFF. Fixed COMPONENTS for TBB

* Fixed file name in install rules

* Added find_dependency for TBB in ie_parallel.cmake

* WA for cmake bug with PACKAGE_PREFIX_DIR

* Fixed no-deprecation to fix speech-library build

* Reverted version from 2.1.0 to 2.1

* Revert "Reverted version from 2.1.0 to 2.1"

This reverts commit 7cb5d15.

* Added versions to cmake

* Added versions to ie_version.hpp

* Returned custom version file back

* Added InferenceEngineConfig-version.cmake to share as well

* Disabled one more GPU test

* Added one more WA for CI

* WA for CI issue for C API

* Added InferenceEngineConfig-version.cmake to share as well

* Added verison parsing from ie_version.hpp

* Revert "[CPU] Add Roll support (openvinotoolkit#5112)"

This reverts commit 5d8f209.

* Revert "[CPU] windows_Interpolate_fused-FQ_nearest-mode_nspc-layout_fix (openvinotoolkit#5317)"

This reverts commit 0808975.

* Revert "[INT8][BF16] INT8 + BF16 feature was enabled (openvinotoolkit#5059)"

This reverts commit 7d2ec02.

* Support for components

* No version for IEDevScripts package

* Removed IE_VS_VER_HAS_VERSION from vs_version.rc.in

* Added compatibility for 2.x old versioning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants