Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed extracting TF models with string constants #5110

Merged

Conversation

lazarevevgeny
Copy link
Contributor

Root cause analysis: After merge of #3573 the MO starts to read operations located in the sub-graphs of the main model (While operation body). There is an operation inside containing string constant value. MO fails to read this constant value because it tries to convert it to numpy string and fails.

Solution: Do not try to convert the value to numpy string and use it as is. Similar fix was done for the issue before but this particular line of code was not updated.

Ticket: 47405

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR: N/A
  • Transformation preserves original framework node names: N/A

Validation:

  • Unit tests
  • Framework operation tests
  • Transformation tests: N/A
  • Model Optimizer IR Reader check: done manually

Documentation:

  • Supported frameworks operations list: N/A no new op enabled
  • Guide on how to convert the public model: the instruction exists already
  • User guide update: N/A the instruction exists already

@lazarevevgeny lazarevevgeny marked this pull request as ready for review April 5, 2021 16:17
@lazarevevgeny lazarevevgeny requested review from a team, pavel-esir, vgavrilo and yekruglov and removed request for a team April 5, 2021 16:17
Copy link
Contributor

@pavel-esir pavel-esir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Looks like some tests failed because of testing infrastructure issues not because of changes in the PR

@lazarevevgeny lazarevevgeny merged commit 1d26a56 into openvinotoolkit:master Apr 6, 2021
@lazarevevgeny lazarevevgeny added the category: MO Model Optimizer label Apr 6, 2021
@lazarevevgeny lazarevevgeny added this to the 2021.4 milestone Apr 6, 2021
luo-cheng2021 pushed a commit to luo-cheng2021/openvino that referenced this pull request Apr 7, 2021
* Fixed extracting TF models with string constants

* Fixed parsing strings from the TF models
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Apr 23, 2021
* Fixed extracting TF models with string constants

* Fixed parsing strings from the TF models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: MO Model Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants