Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ MO ] Warnings fix #5105

Merged
merged 5 commits into from
Apr 8, 2021
Merged

Conversation

yekruglov
Copy link
Contributor

@yekruglov yekruglov commented Apr 5, 2021

Root cause analysis: Python interprets \ like regular expression pattern in docstring and raises a lot of warnings. So in some cases it can be difficult to read a log

Solution: Declare each docstring with \ as a row string by prepending r before it

Ticket: 49765

Code:

  • Comments
  • Code style (PEP8)
  • Transformation generates reshape-able IR N/A
  • Transformation preserves original framework node names N/A

Validation:

  • Unit tests N/A
  • Framework operation tests N/A
  • Transformation tests N/A
  • Model Optimizer IR Reader check N/A

Documentation:

  • Supported frameworks operations list N/A
  • Guide on how to convert the public model N/A
  • User guide update N/A

@yekruglov yekruglov added the category: MO Model Optimizer label Apr 5, 2021
@yekruglov yekruglov added this to the 2021.4 milestone Apr 5, 2021
@yekruglov yekruglov requested a review from lazarevevgeny April 5, 2021 09:04
@yekruglov yekruglov requested a review from a team April 5, 2021 09:04
@lazarevevgeny lazarevevgeny requested review from a team, rkazants and achetver and removed request for a team April 5, 2021 10:47
@rkazants
Copy link
Member

rkazants commented Apr 7, 2021

Why don't you cover all files?

@yekruglov
Copy link
Contributor Author

yekruglov commented Apr 7, 2021

Why don't you cover all files?

It is pointless and will take a lot of time. I only covered the files, where it was necessary

I disagree because it seems to me that this approach must be established on the regular basis because comments for transformations are regularly updated, new transformations along with comments are added, and other service mark symbols may affect. So your fix can be potentially broken in future.

@lazarevevgeny lazarevevgeny merged commit ca889f5 into openvinotoolkit:master Apr 8, 2021
mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Apr 23, 2021
* warnings fix

* remove redundant backslash

* add whitespace in the error message
@yekruglov yekruglov deleted the fix_warnings branch May 4, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: MO Model Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants