Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IE CLDNN] Bugfix in eltwise ref and optimizing for fsv4 layout #5104

Merged
merged 7 commits into from
May 25, 2021

Conversation

byungilm
Copy link
Contributor

@byungilm byungilm commented Apr 5, 2021

  • Bugfix in CheckInputsOutputNoPitchSameDims
  • Bugfix in eltwise_vload8
  • Add testcases

Signed-off-by: Min, Byungil [email protected]

Details:

  • Add exception logic to CheckInputsOutputNoPitchSameDims and eltwise if the feature size is not fit to block size of fsvN

@byungilm byungilm added the category: GPU OpenVINO GPU plugin label Apr 5, 2021
@byungilm byungilm requested a review from geunhwan April 5, 2021 09:01
@byungilm byungilm requested review from a team as code owners April 5, 2021 09:01
format::type out_format;
};

struct eltwise_same_input_test : testing::TestWithParam<eltwise_same_input_test_params>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be quite similar to generic_eltwise_test. What is the difference?

Copy link
Contributor Author

@byungilm byungilm Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to make a simple test that I represented the existing target bug.
Should it be supposed to be merged to generic test?

@byungilm byungilm force-pushed the eltwise_bugfix branch 2 times, most recently from 8af96fc to b0d83cc Compare April 9, 2021 08:51
@byungilm
Copy link
Contributor Author

byungilm commented Apr 12, 2021

@vladimir-paramuzov , @lznamens I applied all comments. It passed CI.

@byungilm byungilm closed this Apr 14, 2021
@byungilm byungilm reopened this Apr 14, 2021
@byungilm byungilm changed the title [IE CLDNN] Bugfix in eltwise ref for fsv4 layout [IE CLDNN] Bugfix in eltwise ref and optimizing for fsv4 layout Apr 14, 2021
@vladimir-paramuzov vladimir-paramuzov added this to the 2021.4 milestone Apr 14, 2021
@byungilm byungilm force-pushed the eltwise_bugfix branch 2 times, most recently from 6690db3 to 68ee94a Compare May 20, 2021 06:15
+ Bugfix in CheckInputsOutputNoPitchSameDims
+ Bugfix in eltwise_vload8
+ Add testcases

Signed-off-by: Min, Byungil <[email protected]>
byungilm and others added 6 commits May 24, 2021 13:40
Signed-off-by: Min, Byungil <[email protected]>
Signed-off-by: byungilm <[email protected]>
Signed-off-by: Min, Byungil <[email protected]>
Signed-off-by: byungil.min <[email protected]>
@vladimir-paramuzov vladimir-paramuzov merged commit e41f378 into openvinotoolkit:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants