Fixed framework name attribute in mapping file. #5046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popovaan
requested review from
a team,
pavel-esir,
mvafin and
sadolini
and removed request for
a team
sadolini
reviewed
Apr 7, 2021
sadolini
approved these changes
Apr 7, 2021
mvafin
approved these changes
Apr 7, 2021
lazarevevgeny
suggested changes
Apr 8, 2021
|
@iimironov , please, review the MxNet part. |
|
@popovaan, also we need init tests to cover new changes. Consider adding MO tests in the tests-private repo. |
iimironov
reviewed
Apr 8, 2021
lazarevevgeny
approved these changes
Apr 8, 2021
iimironov
approved these changes
Apr 8, 2021
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Apr 23, 2021
* Fixed framework name attribute for onnx, mxnet. * Fixed framework name attribute for caffe. * Removed unnecessary attribute setting from add_opoutput() * Added identity nodes adding to outputs in mxnet loader. * Removed unnecessary reformat. * Removed unnecessary reformat. * Added check for empty name. * Used nodes indices instead of node names in loader. * Code refactoring, small bug fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause analysis:
For some frameworks original operation name was saved incorrectly. Before adding to "fw_tensor_debug_info" it was passed to graph.unique_id() which added id in case if graph has a node with the same name.
Another issue was that in mxnet models tensor names of output nodes were not saved to IR. This happed due to absence of output edges on output nodes where tensor information is stored.
Solution:
Store original framework name in "fw_tensor_debug_info" attribute without passing through graph.unique_id().
Add identity nodes to output nodes in mxnet loader for storing tensor information. These nodes are removed when Result nodes are added to graph.
Ticket: 52131
Code:
Validation:
Documentation: