-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPU] Added support for network inputs and outputs with the same name. #5000
Merged
dmitry-gorokhov
merged 11 commits into
openvinotoolkit:master
from
maxnick:ParameterResultNetwork
May 28, 2021
Merged
[CPU] Added support for network inputs and outputs with the same name. #5000
dmitry-gorokhov
merged 11 commits into
openvinotoolkit:master
from
maxnick:ParameterResultNetwork
May 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnick
changed the title
[CPU] Added support for the same names of network inputs and outputs.
[CPU] Added support for network inputs and outputs with the same name.
Mar 30, 2021
maxnick
requested review from
vladislav-volkov and
mandrono
and removed request for
a team
March 30, 2021 16:28
@vladislav-volkov, @mandrono could you please review? |
mandrono
reviewed
Apr 4, 2021
inference-engine/src/plugin_api/cpp_interfaces/impl/ie_infer_request_internal.hpp
Outdated
Show resolved
Hide resolved
inference-engine/tests/functional/plugin/cpu/subgraph_tests/src/param_result_custom_blob.cpp
Show resolved
Hide resolved
Closed
3 tasks
maxnick
force-pushed
the
ParameterResultNetwork
branch
from
April 13, 2021 12:57
a477546
to
55c3b81
Compare
Closed
3 tasks
mandrono
approved these changes
Apr 13, 2021
@mandrono Thank you!!! |
maxnick
force-pushed
the
ParameterResultNetwork
branch
3 times, most recently
from
April 26, 2021 08:44
65cb493
to
46896d0
Compare
maxnick
force-pushed
the
ParameterResultNetwork
branch
from
May 7, 2021 09:38
46896d0
to
5f39c3a
Compare
inference-engine/tests/functional/plugin/cpu/subgraph_tests/src/param_result_custom_blob.cpp
Show resolved
Hide resolved
maxnick
force-pushed
the
ParameterResultNetwork
branch
from
May 12, 2021 09:10
5f39c3a
to
f6c7687
Compare
@dmitry-gorokhov, all comments have been applied. |
dmitry-gorokhov
approved these changes
May 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge after internal validation
maxnick
force-pushed
the
ParameterResultNetwork
branch
2 times, most recently
from
May 25, 2021 15:58
94a1181
to
2942a54
Compare
maxnick
force-pushed
the
ParameterResultNetwork
branch
from
May 27, 2021 06:56
2942a54
to
7ced6a2
Compare
dmitry-gorokhov
approved these changes
May 28, 2021
yekruglov
pushed a commit
to yekruglov/openvino
that referenced
this pull request
Jun 7, 2021
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
The purpose of this PR is to support, at the CPU plug-in level, the case where both the input and the output of the network have the same name. This case is valid, for example, in Parameter->Result network. Now in case if the network inputs and outputs have the same name they will share the same data blob.
Tickets: