Revise Concat op #4543
Merged
Revise Concat op #4543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blesniewski Please set the milestone |
lazarevevgeny
approved these changes
Mar 3, 2021
|
Why "DO NOT MERGE"? If this is a regression in 2021.3 then we should merge it in 2021.3. |
I asked not to merge anything which is not critical because today is the Code Freeze and I don't want to take a risk to potentially introduce new issues which we didn't think of right now. I don't see this change as regression or critical, it just adds additional input validation and as I experienced before such additional check can break models from E2E (but in theory it shouldn't). |
jdanieck
approved these changes
Mar 3, 2021
ilyachur
approved these changes
Mar 3, 2021
|
@openvinotoolkit/openvino-ngraph-maintainers This PR can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
validate_and_infer_typesneeded additional check for an edge-caseaxisattribute value.Unit tests were added to cover this change.
Tickets: