-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PP] Support for FP16 in Reorder cases #4427
[PP] Support for FP16 in Reorder cases #4427
Conversation
Can we move pre-processing tests from deprecated folder? |
9b2459c
to
b56f5f6
Compare
Sure we can, but IMHO it should be done as a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@anton-potapov please fix Split and Merge test failure for Debian 9 ARM and Ubuntu18. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
6c7a9cd
to
4fa9012
Compare
170ecfc
to
a29fa4b
Compare
- added basic support for FP16 (plain wrapper over int16_t) - extended Split/Merge operations to support it - tests
a29fa4b
to
e4d98e8
Compare
@ilya-lavrenov could you please merge it ? |
@ilya-lavrenov ping :) |
@ilyachur Please take a look. |
Looks good for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move preproc tests from deprecated folder in the next PR.
@ilyachur thank you very much! |
- added basic support for FP16 (plain wrapper over int16_t) - extended Split/Merge operations to support it - tests
This tiny PR fixes up FP16 support introduced in #4141
Details:
@nikita-kud , FYI