Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PP] Support for FP16 in Reorder cases #4427

Merged

Conversation

anton-potapov
Copy link
Contributor

@anton-potapov anton-potapov commented Feb 19, 2021

This tiny PR fixes up FP16 support introduced in #4141

Details:

  • added basic support for FP16 (plain wrapper over uint16_t)
  • extended Split/Merge operations to support it
  • tests

@nikita-kud , FYI

@anton-potapov anton-potapov requested review from a team February 19, 2021 13:04
@openvino-pushbot openvino-pushbot added category: inference OpenVINO Runtime library - Inference category: IE Tests OpenVINO Test: plugins and common labels Feb 19, 2021
@ilyachur
Copy link
Contributor

Can we move pre-processing tests from deprecated folder?

@anton-potapov anton-potapov force-pushed the preproc_fp16_reorder branch 2 times, most recently from 9b2459c to b56f5f6 Compare March 1, 2021 08:25
@anton-potapov
Copy link
Contributor Author

Can we move pre-processing tests from deprecated folder?

Sure we can, but IMHO it should be done as a separate PR

Copy link
Contributor

@smirnov-alexey smirnov-alexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@anna-khakimova
Copy link

@anton-potapov please fix Split and Merge test failure for Debian 9 ARM and Ubuntu18.

Copy link

@rgarnov rgarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ilya-lavrenov ilya-lavrenov added this to the 2021.4 milestone Mar 5, 2021
@anton-potapov anton-potapov force-pushed the preproc_fp16_reorder branch 2 times, most recently from 6c7a9cd to 4fa9012 Compare March 11, 2021 11:43
@anton-potapov anton-potapov force-pushed the preproc_fp16_reorder branch 2 times, most recently from 170ecfc to a29fa4b Compare March 22, 2021 22:14
 - added basic support for FP16 (plain wrapper over int16_t)
 - extended Split/Merge operations to support it
 - tests
@anton-potapov
Copy link
Contributor Author

@ilya-lavrenov could you please merge it ?

@anton-potapov
Copy link
Contributor Author

@ilya-lavrenov ping :)

@anna-khakimova
Copy link

@ilyachur Please take a look.

@anna-khakimova
Copy link

Looks good for me.

Copy link

@anna-khakimova anna-khakimova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

Copy link
Contributor

@ilyachur ilyachur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move preproc tests from deprecated folder in the next PR.

@ilyachur ilyachur merged commit 54b6c77 into openvinotoolkit:master Apr 7, 2021
@anton-potapov
Copy link
Contributor Author

@ilyachur thank you very much!

mryzhov pushed a commit to mryzhov/openvino that referenced this pull request Apr 23, 2021
- added basic support for FP16 (plain wrapper over int16_t)
 - extended Split/Merge operations to support it
 - tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants