Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy constant type in MO #4361

Closed
wants to merge 1 commit into from

Conversation

mvafin
Copy link
Contributor

@mvafin mvafin commented Feb 16, 2021

Type of np.iinfo(np.int32).max can be int32 or int64 depending on numpy version. Found manually.

@mvafin mvafin requested review from yekruglov and a team February 16, 2021 10:37
@openvino-pushbot openvino-pushbot added the category: MO Model Optimizer label Feb 16, 2021
@mvafin
Copy link
Contributor Author

mvafin commented Feb 16, 2021

Fix not relevant since code will be refactored

@mvafin mvafin closed this Feb 16, 2021
@addisonklinke
Copy link

@mvafin Do you think this could have any impact on #4745?

In that issue I report what appears to be an OpenVINO-caused discrepancy between int32 and int64 dtypes. The dtypes are consistent in the ONNX and XML graphs, but when reading the network into OpenVINO's inference engine, it appears to infer the wrong dtype for nodes where that attribute is not explicitly specified

@mvafin mvafin deleted the fix/int64_type branch February 9, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: MO Model Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants