Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Remove linking libonnx from unit-test #4298

Conversation

t-jankowski
Copy link
Contributor

@t-jankowski t-jankowski commented Feb 11, 2021

Since logic of get_function_op_with_version test is covered by onnx_expand_function test, it is removed and its dependencies cleaned up. Removing direct link unit-test to libonnx also solves problems found in PRs #4107 and #4025.
Note that unit-test still depends on libonnx include dirs and compile defs.

Ticket: 47605

@t-jankowski t-jankowski self-assigned this Feb 11, 2021
@t-jankowski t-jankowski requested a review from a team February 11, 2021 14:45
@openvino-pushbot openvino-pushbot added the category: Core OpenVINO Core (aka ngraph) label Feb 11, 2021
@t-jankowski t-jankowski force-pushed the tj/ngraph-test/remove-libonnx-linkage branch from 4c1afcc to d2b28ba Compare February 11, 2021 14:51
@t-jankowski t-jankowski force-pushed the tj/ngraph-test/remove-libonnx-linkage branch from 1f46eae to 64aa647 Compare February 11, 2021 22:01
@ilya-lavrenov ilya-lavrenov added this to the 2021.3 milestone Feb 12, 2021
@t-jankowski t-jankowski changed the title Remove linking libonnx from unit-test [ONNX] Remove linking libonnx from unit-test Feb 12, 2021
@ilyachur ilyachur merged commit b800f08 into openvinotoolkit:master Feb 15, 2021
a-sidorova added a commit to a-sidorova/openvino that referenced this pull request Feb 15, 2021
* fix ss

* successfully converted

* successfully run moved infer and normalizer unit-tests

* successfully rewritten StridedSlice infer unittests

* int64 array

* Successfully converter crash-when-loading, xj_feauture and toy nets (cherry-picked maxpoolV4 and tf_broadcast_ext)

* successfully moved PermuteAttrs to general mechanism

* successfully converted xj_feauture and crash when loading with the new rewritten SS infer

* fixed get_shape_from_slice and moved to common utils

* fixed extending masks and some other

* some refactoring

* fixed extending masks in extractor, fixed licence year and some other code clearing

* corrected a couple of unittests

* fox permute for 5 rank slice and 4 rank inputs/

* WIP

* Added comments

* fixed StridedSlice in ProposalMutation.py

* rechecked shape_infer unittests added some new cases

* added shape_infer unit-tests after StridedSliceNormalizer pass and Permute unit-tests

* corrected unittests

* Applied review comments

* general permutations for inputs implemented, corrected ellipsis unrolling when shrink_axis is at the beginning, some other corrections

* removed code duplication in infer and normalizer, moved 'slices' attr normalizing to StridedSliceNormalizer.py

* removed some code duplication and other minor improvements

* Added tests

* minor corrections

* [GNA] Support 1d tensors (openvinotoolkit#4270)

* [OpenVINO Scripts] Updated with RHEL8 (openvinotoolkit#4296)

* Updated install_NEO_OCL_driver.sh & install_openvino_dependencies.sh with rhel8 case

* install_NEO_OCL_driver: Fixed conditional

* script: Updated with actual revisions

* [CPU] MKLDNN NCHW pooling primitive performance fix. (openvinotoolkit#4235)

* [IE][VPU]: Check memory capacity after finding the corresponding device (openvinotoolkit#4314)

This issue relates to multi-device mode.
While we are trying to allocate a graph on one of the devices we should check memory capacity only for the corresponding device, not for the last opened as far devices may have different memory capacity or the latest opened device may have still not sent its attributes (including memory capacity)

* Azure CI: Enable IB initiators as helpers

* Result rename operation (openvinotoolkit#4242)

* Added result rename operation

* Optimize imports

* Added ResultRename to package_BOM

* ResultRename moved to the end of back phase, code refactoring

* Revert incorrect changes

* Optimize imports

* Added comments and optimized imports.

* DPC++ link error workaround. (openvinotoolkit#4192)

* DPC++ link error workaround.

OpenVINO C++ program failed to link when DPC++ compiler is used.
'make_shared_blob' causes 'unresolved external symbol' error on linking.
Commented out some __clang__ specific directives to workaround the issue in "ie_blob.h".

* DPC++ compatibility issue fix #2

1. Removed type-by-type template class definition for __clang__.
2. Modified TBlob() destructor. The 'unresolved reference' error occur again if I left 'virtual ~TBlob();' only. It seems it needs to be 'virtual ~TBlob() {};'.

* DPC++ compatibility fix #3 - Add DPC++ conditional code

Uses '__SYCL_COMPILER_VERSION' predefined macro to check if the compiler is a DPC++ or not.
Added conditional directive to switch code based of the detected compiler.
NOTE: User program must include <CL/sycl.hpp>, or the '__SYCL_COMPILER_VERSION' macro won't be defined and this fix won't take effect.

* DPC++ compatibility issue fix #4

Changed from #ifdef to #if + logical formulas.

* DPC++ compatibility issue fix #5

Added compiler check logic in src/ie_rtti.cpp

* DPC++ Compatibility issue #6 - ie_parameter.cpp

Added compiler check macro for DPC++ to ie_parameter.cpp as well.

Co-authored-by: Yasunori Shimura <[email protected]>

* Azure CI: Disable IB stop

* Remove generic ie op (openvinotoolkit#4213)

* Removed legacy IE shape infer

* Removed GenericIE operation

* Removed legacy shape infer tests

* Removed legacy test with legacy IE reshape

* Fixed compilation issues related to removal of GenericIE

* Fixed one more compilation issue with clDNN

* Fixed test for reading experimental ops

* Updated tests and make IR Reader to load old experimenal and extension ops as opset6

* Change opset of some ops only if they are currently experimental/extension to avoid situation like opset1::Proposal -> opset6::Proposal

* Removed more legacy code

* Returned back code removed by mistake

* Fixed issues related to incorrect merge with master

* Merge fixes

* Fixed unit tests which starts to fail because now loading the model with unknown operation is failed earlier

* Removed incorrectly added code

Co-authored-by: Evgeny Lazarev <[email protected]>

* [IE CLDNN] Added CTCGreedyDecoderSeqLen operation (openvinotoolkit#4119)

* [CPU] Refactors jitters for nGraph interop (openvinotoolkit#4255)

* [IE CLDNN] Fixed CTCGreedyDecoderSeqLenLayerTest gpu instances (openvinotoolkit#4326)

* Fix comparison of constant with short float NAN values (openvinotoolkit#4299)

* fix comparison of constant with short float NAN values

* adjust precision, remove elvises

* more templates

* add ir serialization  test with float16 const

* remove unused prototxt

* [ONNX] Remove linking libonnx from unit-test (openvinotoolkit#4298)

* Remove linking libonnx from unit-test

* Consider all flavors of protobuf libraries

* Avoid passing on NOTFOUND properties

* Set system deps for mac

* Revert include dirs set up

* wider range of unittests added (froze the number)

* ONNX RNN/GRU enable dynamic input shape (openvinotoolkit#4241)

* Add support for custom ONNX operator PriorBoxClustered (openvinotoolkit#4202)

* review comments applied

* Force test use bash for setupvars.sh (openvinotoolkit#4321)

setupvars.sh is incomatible with sh shell.

* enabled skipped unit-test

* comment corrections

Co-authored-by: Pavel Esir <[email protected]>
Co-authored-by: Elizaveta Lobanova <[email protected]>
Co-authored-by: Artyom Anokhov <[email protected]>
Co-authored-by: Maksim Kutakov <[email protected]>
Co-authored-by: Maksim Doronin <[email protected]>
Co-authored-by: Alexander Zhogov <[email protected]>
Co-authored-by: Anastasia Popova <[email protected]>
Co-authored-by: Yasunori Shimura <[email protected]>
Co-authored-by: Yasunori Shimura <[email protected]>
Co-authored-by: Evgeny Lazarev <[email protected]>
Co-authored-by: Evgeny Lazarev <[email protected]>
Co-authored-by: Roman Lyamin <[email protected]>
Co-authored-by: Marina Kolpakova <[email protected]>
Co-authored-by: Vladimir Paramuzov <[email protected]>
Co-authored-by: Bartosz Lesniewski <[email protected]>
Co-authored-by: Tomasz Jankowski <[email protected]>
Co-authored-by: Katarzyna Mitrus <[email protected]>
Co-authored-by: Bartosz Sledz <[email protected]>
Co-authored-by: Andrey Somsikov <[email protected]>
@t-jankowski t-jankowski deleted the tj/ngraph-test/remove-libonnx-linkage branch June 23, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants