Fix TI deserialization #4285
Merged
Fix TI deserialization #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyachur
reviewed
Feb 11, 2021
…is reported during inserting to function Xml parameter/result order is irrelevant now.
pelszkow
force-pushed
the
fix/44194/Visitor_API_is_not_suported_in_TI_and_Loop
branch
from
09c028e to
036e13a
Compare
pelszkow
force-pushed
the
fix/44194/Visitor_API_is_not_suported_in_TI_and_Loop
branch
from
1f1d83d to
a796a2a
Compare
ilyachur
reviewed
Feb 12, 2021
|
@pelszkow Could you please add tests for your changes? I think we need to have tests which will show improvements. Thank you! |
pelszkow
force-pushed
the
fix/44194/Visitor_API_is_not_suported_in_TI_and_Loop
branch
from
43fe35a to
a389e66
Compare
jdanieck
approved these changes
Feb 12, 2021
ilyachur
approved these changes
Feb 12, 2021
pelszkow
deleted the
fix/44194/Visitor_API_is_not_suported_in_TI_and_Loop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required because we can't depend on xml node sorting/ordering algorithm. Sorting algo start building nodes ids order based on Results nodes which might be serialize in different order than it was read from xml (xml order won't be preserve).
We have to have some mechanism for renumerate input (index/order) and store indexes in In/Out Description.
Ticket 44194.