Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added coverage for template plugin #4234

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Added coverage for template plugin #4234

merged 1 commit into from
Feb 9, 2021

Conversation

ilya-lavrenov
Copy link
Contributor

No description provided.

@ilya-lavrenov ilya-lavrenov added the category: build OpenVINO cmake script / infra label Feb 8, 2021
@ilya-lavrenov ilya-lavrenov added this to the 2021.3 milestone Feb 8, 2021
@ilya-lavrenov ilya-lavrenov requested review from nkogteva and a team February 8, 2021 16:15
@openvino-pushbot openvino-pushbot added the category: inference OpenVINO Runtime library - Inference label Feb 8, 2021
ilyachur
ilyachur reviewed Feb 9, 2021
View reviewed changes
cmake/developer_package/features.cmake
@@ -26,7 +26,7 @@ ie_option (ENABLE_SANITIZER "enable checking memory errors via AddressSanitizer"

ie_option (ENABLE_THREAD_SANITIZER "enable checking data races via ThreadSanitizer" OFF)

ie_dependent_option (COVERAGE "enable code coverage" OFF "CMAKE_CXX_COMPILER_ID STREQUAL GNU" OFF)
ie_dependent_option (ENABLE_COVERAGE "enable code coverage" OFF "CMAKE_CXX_COMPILER_ID STREQUAL GNU" OFF)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update CI scripts I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately, CI does not use this variable. It passes all flags and does all magic out of IE sources. E.g. cmake -E env CXXFLAGS="--coverage" and so on

@ilya-lavrenov ilya-lavrenov merged commit 0c39d5b into openvinotoolkit:master Feb 9, 2021
@ilya-lavrenov ilya-lavrenov deleted the coverage branch February 9, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyachur ilyachur ilyachur approved these changes

@nkogteva nkogteva Awaiting requested review from nkogteva

Assignees
No one assigned
Labels
category: build OpenVINO cmake script / infra category: inference OpenVINO Runtime library - Inference
Projects
None yet
Milestone
2021.3
Development

Successfully merging this pull request may close these issues.
3 participants
@ilya-lavrenov @ilyachur @openvino-pushbot