Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Handle optional outputs for Dropout and MaxPool #4143

Merged
merged 26 commits into from
Feb 15, 2021
Merged

[ONNX] Handle optional outputs for Dropout and MaxPool #4143

merged 26 commits into from
Feb 15, 2021

Conversation

mbencer
Copy link
Contributor

@mbencer mbencer commented Feb 2, 2021

Tikcet: 38705

@mbencer mbencer requested review from mitruska and tsocha February 2, 2021 13:40
@mbencer mbencer self-assigned this Feb 2, 2021
@mbencer mbencer requested a review from a team February 2, 2021 13:40
@openvino-pushbot openvino-pushbot added the category: Core OpenVINO Core (aka ngraph) label Feb 2, 2021
tsocha
tsocha suggested changes Feb 8, 2021
View reviewed changes
ngraph/frontend/onnx_import/src/op/dropout.cpp Outdated Show resolved Hide resolved
ngraph/frontend/onnx_import/src/op/dropout.cpp Outdated Show resolved Hide resolved
@mbencer mbencer requested a review from tsocha February 8, 2021 10:32
@mbencer mbencer requested a review from mitruska February 8, 2021 13:52
@mbencer mbencer requested a review from a team February 10, 2021 10:54
@mbencer mbencer requested a review from mitruska February 10, 2021 15:10
mitruska
mitruska approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@mitruska mitruska left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM, just some extra thoughts.

ngraph/frontend/onnx_import/src/op/dropout.cpp Outdated Show resolved Hide resolved
ngraph/frontend/onnx_import/src/op/dropout.cpp Outdated Show resolved Hide resolved
GlebKazantaev
GlebKazantaev approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@GlebKazantaev GlebKazantaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve convert precision part.

@postrational postrational merged commit d821ec4 into openvinotoolkit:master Feb 15, 2021
@mbencer mbencer deleted the mbencer/HandleOnnxOptionalOutput branch March 4, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsocha tsocha tsocha approved these changes

@tomdol tomdol tomdol approved these changes

@mitruska mitruska mitruska approved these changes

@GlebKazantaev GlebKazantaev GlebKazantaev approved these changes

@ilyachur ilyachur ilyachur approved these changes

@postrational postrational postrational approved these changes

Assignees

@mbencer mbencer

Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mbencer @postrational @ilyachur @GlebKazantaev @mitruska @tomdol @tsocha @openvino-pushbot