Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group convolution backprop data #4113

Merged
merged 18 commits into from
Feb 8, 2021
Merged

Group convolution backprop data #4113

merged 18 commits into from
Feb 8, 2021

Conversation

jdanieck
Copy link
Contributor

@jdanieck jdanieck commented Feb 1, 2021 •
edited
Loading

GroupConvolutionBackpropData reference implementation developed. Ticket 37444.

Implementation details:

  • Reused runtime::reference::convolution_backprop_in() for actual operation calculation
  • Removed GroupConvolutionBackpropData from int_executable
  • Added GroupConvolutionBackpropData to evaluates_map
  • SLT tests extended by 1-D GroupConvolutionBackpropData tests
  • Serialization SLT added
  • Specification refactored
  • Ngraph operation refactored

ggalieroc and others added 16 commits February 1, 2021 10:33
@ggalieroc
GroupConvolutionBackpropData: Added backend unit tests
346a524
@ggalieroc
GroupConvolutionBackpropData: Refactor SLT and added tests for 1D
72c01cb
@ggalieroc
GroupConvolutionBackpropData: Added Serialization tests
cf16f11
@ggalieroc
GroupConvolutionBackpropData: Added GroupConvolutionBackpropData refe…
dfe774d 
…rence implementation
@jdanieck
GroupConvolutionBackpropData specification refactoring.
4167c54
@jdanieck
Merge remote-tracking branch 'upstream/master' into group_convolution…
23b24f0 
…_backprop_data
@ggalieroc
GroupConvolutionBackpropData: Added validation node checks for the op
b017b48
@ggalieroc
GroupConvolutionBackpropData: Copyright year fixed
40fdeec
@ggalieroc
GroupConvolutionBackpropData: Enhanced output shape inference with dy…
4cc5c78 
…namic shapes
@ggalieroc
Merge remote-tracking branch 'upstream/master' into group_convolution…
dc8e437 
…_backprop_data
@ggalieroc
GroupConvolutionBackpropData: Remove redefinition of helper variables
f704edb
@jdanieck
Spec refactoring: add ticks to types and layouts.
a3e0c5e
@jdanieck
Minor refactoring.
51610aa
@ggalieroc
GroupConvolutionBackpropData: Moved backend tests from GroupConvoluti…
99c69c9 
…on to corresponding file
@ggalieroc
GroupConvolutionBackpropData: Improved output shape inference for ful…
6b9b3f5 
…ly dynamic inputs
@ggalieroc
GroupConvolutionBackpropData: Clean up type_prop tests
8f6084f
@ggalieroc-zz ggalieroc-zz marked this pull request as ready for review February 4, 2021 15:35
@ggalieroc-zz ggalieroc-zz requested a review from a team as a code owner February 4, 2021 15:35
@ggalieroc-zz ggalieroc-zz requested review from a team February 4, 2021 15:35
@GlebKazantaev GlebKazantaev removed the request for review from a team February 4, 2021 20:53
@ggalieroc-zz ggalieroc-zz requested a review from iefode February 5, 2021 08:51
@ggalieroc-zz ggalieroc-zz added the category: Core OpenVINO Core (aka ngraph) label Feb 5, 2021
@ggalieroc-zz ggalieroc-zz self-assigned this Feb 5, 2021
@jdanieck jdanieck requested a review from iefode February 7, 2021 15:06
@jdanieck
Copy link
Contributor Author

jdanieck commented Feb 8, 2021

@lazarevevgeny following the convention from previous PRs please look at the spec - it is written by me, I followed already established conventions. Ilya already approved, so we're waiting for you and then we can merge.

iefode
iefode approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@iefode iefode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IE Test part LGTM

@iefode iefode merged commit 0acd153 into openvinotoolkit:master Feb 8, 2021
@jdanieck jdanieck deleted the group_convolution_backprop_data branch June 16, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazarevevgeny lazarevevgeny lazarevevgeny approved these changes

@iefode iefode iefode approved these changes

@ilyachur ilyachur ilyachur approved these changes

@ggalieroc-zz ggalieroc-zz Awaiting requested review from ggalieroc-zz

Assignees

@ggalieroc-zz ggalieroc-zz

Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jdanieck @ilyachur @iefode @lazarevevgeny @ggalieroc-zz @ggalieroc