Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeformableConvolution specification refactoring. #4101

Merged

Conversation

jdanieck
Copy link
Contributor

@jdanieck jdanieck commented Jan 31, 2021

DeformableConvolution specification refactored. I used MXNet as a reference. Both MXNet and CPU plugin supports only 2D so I stated this explicitly in specification.

Details:

  • Changed input & output tensor types to 'any floating point'
  • Added short description
  • Extended detailed description
  • Added examples
  • Added description of inputs & output rank and layout

@jdanieck jdanieck requested a review from a team as a code owner January 31, 2021 18:57
@jdanieck jdanieck self-assigned this Jan 31, 2021
@openvino-pushbot openvino-pushbot added the category: docs OpenVINO documentation label Jan 31, 2021
@jdanieck jdanieck requested a review from iimironov February 1, 2021 10:50
@pszmel pszmel self-requested a review February 1, 2021 12:39
@jdanieck jdanieck requested a review from yury-intel February 2, 2021 10:45
@jdanieck
Copy link
Contributor Author

jdanieck commented Feb 7, 2021

@yury-intel as you were designated to represent CPU plugin team on the topic of DeformableConvolution, please have a look at this PR and confirm that it is aligned with CPU plugin implementation. I'd like to merge it.

Copy link
Contributor

@yury-intel yury-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct

@jdanieck
Copy link
Contributor Author

jdanieck commented Feb 8, 2021

@lazarevevgeny looks ready to merge

@lazarevevgeny lazarevevgeny merged commit f5fb37c into openvinotoolkit:master Feb 8, 2021
@jdanieck jdanieck deleted the deformable_convolution_spec branch February 8, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: docs OpenVINO documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants