-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeformableConvolution specification refactoring. #4101
Merged
lazarevevgeny
merged 5 commits into
openvinotoolkit:master
from
jdanieck:deformable_convolution_spec
Feb 8, 2021
Merged
DeformableConvolution specification refactoring. #4101
lazarevevgeny
merged 5 commits into
openvinotoolkit:master
from
jdanieck:deformable_convolution_spec
Feb 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdanieck
commented
Jan 31, 2021
lazarevevgeny
suggested changes
Feb 3, 2021
At the current moment CPU plugin and MXnet implemenatations supports only 2D case.
lazarevevgeny
approved these changes
Feb 7, 2021
@yury-intel as you were designated to represent CPU plugin team on the topic of DeformableConvolution, please have a look at this PR and confirm that it is aligned with CPU plugin implementation. I'd like to merge it. |
yury-intel
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct
@lazarevevgeny looks ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeformableConvolution specification refactored. I used MXNet as a reference. Both MXNet and CPU plugin supports only 2D so I stated this explicitly in specification.
Details: